Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic operator cannot be removed #123

Closed
mbiesiad opened this issue Mar 14, 2022 · 3 comments
Closed

Arithmetic operator cannot be removed #123

mbiesiad opened this issue Mar 14, 2022 · 3 comments
Labels
bug Something isn't working math package

Comments

@mbiesiad
Copy link

mbiesiad commented Mar 14, 2022

Describe the bug
Arithmetic operator cannot be removed using DEL button.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://engine.presearch.org/search?q=calculator
  2. Type 2+ or 3 *
  3. Try undo last typed char (in this case: + or *)
  4. See issue

Expected behavior
Deleting arithmetic operator (+, -. *, /) is allowed, similar like currently for typed last number.

Additional context
It's a little bit similar like #124 but use case is little different.
Here user wants to remove the arithmetic mark to correct the last entered number or even change the operator (there, user accidentally entered an artitmetic wrongly and wants to easily change it).

Best wishes,

@Hkataya
Copy link
Contributor

Hkataya commented Mar 19, 2022

Hey @mbiesiad,
I implemented a fix for this issue and raised a PR for it. This is my first contribution to the project though so not sure who should review the PR.

@mbiesiad
Copy link
Author

Hi Hkataya, sounds great! 🎉

@jejopl
Copy link
Collaborator

jejopl commented Mar 29, 2022

@Hkataya pushed your PR, good job 👍 It will be pushed to production in day or two

@jejopl jejopl closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working math package
Projects
None yet
Development

No branches or pull requests

3 participants