Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating an item from all content and from the bookmarklet causes the nomination count to equal 0 #998

Open
regan008 opened this issue Feb 26, 2018 · 5 comments
Assignees

Comments

@regan008
Copy link
Contributor

Likely related to #985, I am noticing that the following happens:

  1. an item is nominated from all content and the count of nominations is 1
  2. the same item is is nominated from the bookmarklet and the count decreases to 0
@regan008 regan008 added the bug label Feb 26, 2018
@regan008 regan008 added this to the 5.1 milestone Feb 26, 2018
@regan008
Copy link
Contributor Author

regan008 commented Feb 26, 2018

We can discuss it tomorrow but perhaps the best course of action is to push this issue and the related commits in #985 to the next milestone.

@jccatalano
Copy link

This is related to #985 along with other closed issues that #985 is intended to resolve see #960 #961 #962

@AramZS
Copy link
Member

AramZS commented Feb 26, 2018

As a bookmarklet-related error for a fringe case--nominating from feed and then bookmarklet seems much less likely than nominated and then sending to draft from all content--let's push this to be resolved by in 5.2.x.

@regan008
Copy link
Contributor Author

I'm don't think this is a fringe case but lets discuss it today.

@jccatalano
Copy link

This is the result of a user un-nominating their own nomination. If multiple users nominate a post via different methods, the count is correct. This issue will only cause the count to be off by 1 if the same user nominates via both methods.

@AramZS AramZS added the wontfix label Dec 3, 2018
@AramZS AramZS removed this from the 5.2 milestone Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants