Skip to content

Commit

Permalink
[-] BO : Fixed position updating issue #PSCSX-2026 PSCSX-1873
Browse files Browse the repository at this point in the history
A change made on March 24th prevented to update the positions correctly in some tabs (like "Attributes/Values". The $position_group_identifier variable would be always populated with 1 or 0 instead of the $this->position_group_identifier value.

This will make the "id" HTML attribute wrong and methods such as ajaxProcessUpdateAttributesPositions() to fail. Fixed it by keeping the change made on March 24th and using getValue() instead of getIsset().
  • Loading branch information
bLeveque42 committed May 9, 2014
1 parent b6b561a commit 0d86a0d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion classes/helper/HelperList.php
Expand Up @@ -182,7 +182,7 @@ public function displayListContent()
{
if ($this->position_identifier)
if (isset($this->position_group_identifier))
$position_group_identifier = Tools::getIsset($this->position_group_identifier) ? Tools::getIsset($this->position_group_identifier) : $this->position_group_identifier;
$position_group_identifier = Tools::getIsset($this->position_group_identifier) ? Tools::getValue($this->position_group_identifier) : $this->position_group_identifier;
else
$position_group_identifier = (int)Tools::getValue('id_'.($this->is_cms ? 'cms_' : '').'category', ($this->is_cms ? '1' : Category::getRootCategory()->id ));
else
Expand Down

0 comments on commit 0d86a0d

Please sign in to comment.