love and like prestashop (but developer or head of blocking every ideas i hate) #31740
Replies: 3 comments
-
Hey @Gruttersshop, you have nice suggestions and it would be great to add them in the core. As far as I know, you already have submitted PRs for them. But we have some contributing rules, and you, I and all the contributors must follow them. You cannot just edit one or another file because it fits your needs. If you want to add some columns to some classes for example, then you have to update the forms on the controllers, update the object model, update the migrations file. It is not only editing an SQL file. We are open to add a feature if this is needed by many people, and validated by some product manager of the team. Unless you don't follow the rules, your contributions cannot be accepted. The people who blocked your PR are right, and I'd do the same. It is the same for discussions, we have some templates, and you don't follow them either. I'm locking here, thank you for understanding. |
Beta Was this translation helpful? Give feedback.
-
we close all your small PRs on purpose because we don't think you understand our feedback, your very first PR was too big and it was suggested to split it, but submitting one file at a time is quite the extreme opposite 😅 We're willing to help you in your contribution process but you seem to ignore all our previous comments and answers on Github. I think the most efficient way would be to chat on our Slack prestashop.slack.com Feel free to subscribe and discuss with me/us about this feature. |
Beta Was this translation helpful? Give feedback.
-
Since there was no activity since March I think we can close this discussion |
Beta Was this translation helpful? Give feedback.
-
but because no one that is head of project prestashop even understands wat siret is not Vat_number or dni or Ape in diverse contact reading module. I have seen that siret is 1 time a DNI and next time a ape an even a vat number. i want to learn how to make a module. because all the time i have to get some one to even try to get my changes on the board and integrated in presta shop some one like out poland or east europa block it. so 1 can't get to stage 2 or 3 or 4. like done. it's so simple change it would even make a huge impact on rest of prestashop. but only clean it up like. using the names correctly. How do i make a module for prestashop that can edit the ps_address and ps_customer ps_store and edit this like by giving more form like putting a Siret number, ape number, vat_number and iban number. that this also goes to database gives like new field like siret, ape, vat_number and iban fields in ps_adress, ps_cusomer and ps_store? then it can edit like tp so it also shows the Siret, ape, vat-number and iban. only if the contomer has filled these in and the shop owner. Then the store will show it like phone number and like fax. Must i by like rewriting class CustomerCore extends ObjectModel?? Can some one help??
![216629789-fa421044-3d90-4fa7-b59e-7fd1de2d9550](https://user-images.githubusercontent.com/124369064/224572730-7bb94ab3-366d-4bdc-a29b-2bd559cc7529.png)
![216618154-4cf330ce-3309-4147-b742-1326dc044346](https://user-images.githubusercontent.com/124369064/224572732-60b57564-5038-401b-9b99-617bb878041d.png)
![216618054-09ea6357-489a-43f9-bb31-cc550a9676e4](https://user-images.githubusercontent.com/124369064/224572734-21650ca2-77a2-49c4-9783-7e2049202310.png)
Beta Was this translation helpful? Give feedback.
All reactions