Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email address in uppercase #13386

Closed
rblaurin opened this issue Apr 12, 2019 · 18 comments · Fixed by #16550
Closed

Email address in uppercase #13386

rblaurin opened this issue Apr 12, 2019 · 18 comments · Fixed by #16550
Labels
1.7.5.0 Affects versions 1.7.5.1 Affects versions 1.7.6.0 Affects versions Bug Type: Bug Email Label: Which BO under menu is concerned Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed Regression Type: regression
Milestone

Comments

@rblaurin
Copy link
Contributor

Describe the bug
When a customer register his/her email address in uppercase, the confirmation email doesn't work as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new account in front office, entering your email address in uppercase (i.e. KHOULOUDBELGHITH@PRESTASHOP.COM)
  2. Go to your inbox and see the confirmation email. You will see something like HELLO {FIRSTNAME} {LASTNAME}

Additionnal information
PrestaShop version: 1.7.5.1
PHP version: 7.2

@khouloudbelguith
Copy link
Contributor

Hi @rblaurin,

I manage to reproduce the issue with PS:1.7.5.1 and PS:1.7.5.0
I attached a screenshot.
1386

With PS:1.7.4.4=>OK
This issue is added to our bug roadmap.

Thanks!

@khouloudbelguith khouloudbelguith added Bug Type: Bug Email Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression TBR Status: issue to be reproduced 1.7.5.1 Affects versions labels Apr 12, 2019
@marionf
Copy link
Contributor

marionf commented Apr 12, 2019

It's also visible on 1.7.6.0 with new email templates

capture d'écran_1382

@marionf marionf added 1.7.5.0 Affects versions Ready Status: Issue is ready to be worked on and removed TBR Status: issue to be reproduced labels Apr 12, 2019
@marionf marionf removed their assignment Apr 12, 2019
@marionf marionf added the 1.7.6.0 Affects versions label Jun 10, 2019
@colinegin
Copy link

Hello @khouloudbelguith ,

do you still reproduce this issue ? Is it related to #15889 ?

Thanks !

@khouloudbelguith
Copy link
Contributor

Hi @colinegin,

Yes, I manage to reproduce the issue with PS1.7.6.1.
image

No, it is different from #15889, because, this issue occurs in the emails & the other issue is about editing an email from the BO.

Thanks!

@GLSSoftware
Copy link

I can confirm this bug with 1.7.6.1.
To reproduce this behaviour it is suffucient that the mail addess starts with an uppercase e.g. "Volker.Mustermann@example.de". In Germany customers enter their email address very often using uppercase letters. This bug shows up in our live shop almost every week to at least one customer. Because of that the bug should not be marked as 'minor'.

@Allba
Copy link

Allba commented Nov 18, 2019

It have been several months now and still not a fix on a serious issue. This prestashop thing starts to sound like a joke, very disappointed.

@seisnet
Copy link

seisnet commented Nov 25, 2019

i made this fix on classes/Mail.php and it works
row 318 from $toPlugin = $to[0]; to $toPlugin = self::toPunycode($to[0]);
row 321 from $toPlugin = $to; to $toPlugin = self::toPunycode($to);

@colinegin
Copy link

Hello @seisnet ,

thanks for this information, would you be willing to make a pull request with your fix ?

Have a nice day,

Coline

@seisnet
Copy link

seisnet commented Nov 25, 2019

No, i am not wiling sorry

@colinegin
Copy link

Hello @seisnet ,

Thanks for your reply, is there any reason why you are not willing to do so ? Maybe we could help you ?

@seisnet
Copy link

seisnet commented Nov 25, 2019

i have no time to do this. Sorry

@marionf marionf added the PR available Solution: issue is being addressed label Nov 26, 2019
@marionf marionf added this to Backlog in PrestaShop 1.7.7.3 via automation Nov 26, 2019
@marionf marionf moved this from Backlog to To be reviewed in PrestaShop 1.7.7.3 Nov 26, 2019
@colinegin colinegin moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Nov 26, 2019
@khouloudbelguith khouloudbelguith added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Nov 27, 2019
@khouloudbelguith khouloudbelguith moved this from To be tested to To be merged in PrestaShop 1.7.7.3 Nov 27, 2019
@khouloudbelguith khouloudbelguith added this to the 1.7.7.0 milestone Nov 27, 2019
@khouloudbelguith khouloudbelguith added Ready Status: Issue is ready to be worked on and removed Fixed Resolution: issue closed because fixed labels Nov 27, 2019
@khouloudbelguith khouloudbelguith moved this from To be merged to To be tested in PrestaShop 1.7.7.3 Nov 27, 2019
@khouloudbelguith khouloudbelguith removed this from the 1.7.7.0 milestone Nov 27, 2019
@khouloudbelguith khouloudbelguith added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Nov 27, 2019
@khouloudbelguith khouloudbelguith moved this from To be tested to To be merged in PrestaShop 1.7.7.3 Nov 27, 2019
@khouloudbelguith khouloudbelguith added this to the 1.7.7.0 milestone Nov 27, 2019
@seisnet
Copy link

seisnet commented Nov 27, 2019

i made this fix on classes/Mail.php and it works
row 318 from $toPlugin = $to[0]; to $toPlugin = self::toPunycode($to[0]);
row 321 from $toPlugin = $to; to $toPlugin = self::toPunycode($to);

i correct my solution. I pasted it wrong

@skillfulconcept
Copy link

Team, this issue has not been resolved in Prestashop 1.7.6.4. Please reopen this ticket

@khouloudbelguith
Copy link
Contributor

Hi @skillfulconcept
This issue is fixed in the next major version PS1.7.7.0.
Here's the PR: #16550 to fix the issue.

Thanks!

@surffari
Copy link

surffari commented May 7, 2020

Yes, can confirm it's an issue in 1.7.6.4

@alessiomediacy
Copy link

Hi, confirm issue in 1.7.6.7

@khouloudbelguith
Copy link
Contributor

Hi @surffari, @alessiomediacy,

Here's the PR: #16550 to fix the issue.
It is fixed in the next release PS1770.

Thanks!

@Betafer
Copy link

Betafer commented Feb 10, 2021

Problem also present in prestashop 1.7.6.8 with php 7.2.34

Schermata 2021-02-10 alle 15 33 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.5.0 Affects versions 1.7.5.1 Affects versions 1.7.6.0 Affects versions Bug Type: Bug Email Label: Which BO under menu is concerned Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed Regression Type: regression
Projects
No open projects