Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide payment details in Order page #15893

Closed
matks opened this issue Oct 10, 2019 · 6 comments
Closed

Hide payment details in Order page #15893

matks opened this issue Oct 10, 2019 · 6 comments
Labels
migration symfony migration project Order Component: Which BO section is concerned
Milestone

Comments

@matks
Copy link
Contributor

matks commented Oct 10, 2019

Following

It seems we want to remove any payment infos from the order page.

@colinegin @MatShir you confirm ?

I just want to state that I'm against it. PS shows what the payment modules provides. If the module is built correctly, it will provide hidden infos like "XXXX XXXX XXXX XX92" that can be useful for merchants (like customer service requests).

If the module is built in a bad way it might indeed show the full card number which is both insecure and incorrect. But I dont think we should modify PrestaShop behavior because some modules are badly written 😐

@colinegin
Copy link

@LouiseBonnard wdyt ?

@khouloudbelguith khouloudbelguith added the Order Component: Which BO section is concerned label Oct 10, 2019
@LouiseBonnard
Copy link
Contributor

It's under discussion with the legal team, I keep you guys posted about it.

@LouiseBonnard
Copy link
Contributor

📢 UPDATE:

We keep this details block but we hide it when there is no card transaction involved. Is everyone okay with this solution? @MatShir?

@matks
Copy link
Contributor Author

matks commented Oct 15, 2019

📢 UPDATE:

We keep this details block but we hide it when there is no card transaction involved

Can you define "involved" ? Does it mean "if payment method is something else than an online payment using a credit card" ?

@LouiseBonnard
Copy link
Contributor

Yep, currently this block is available for all types of payment but it is irrelevant when the order is paid by bank wire, cheque, cash-on-delivery or any other method unrelated to this information.

@matks matks added the migration symfony migration project label Oct 16, 2019
@colinegin
Copy link

We can close this issue as the fix has been done. See this issue for more info : #15827

@colinegin colinegin added this to Backlog in PrestaShop 1.7.7.3 via automation Oct 22, 2019
@colinegin colinegin moved this from Backlog to Done in PrestaShop 1.7.7.3 Oct 22, 2019
@ghost ghost added this to the 1.7.7.0 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration symfony migration project Order Component: Which BO section is concerned
Projects
No open projects
Development

No branches or pull requests

4 participants