New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jquery-migrate generates many messages in the console #15943
Comments
Ping @PrestaShop/prestashop-core-developers |
@matthieu-rolland It seems that it's the normal behavior with the use of a development version : https://github.com/jquery/jquery-migrate#debugging. Else you can use |
We mustn't use |
@PierreRambaud that's the question, do we consider that those messages should be displayed even in production ? |
I think yes, it's related to the front and only available in console, which means you're watching "js logs". |
Can this be enabled in dev mode and disabled in prod mode? |
We should be able to use: https://github.com/jquery/jquery-migrate/blob/master/src/migratemute.js |
it looks like deprecated messages appears even if we don't use these functions, tried to find a "delegate" function use on FO core and classic files, couldn't find anything BTW, we should maybe check every deprecated messages, in order to be sure we don't use any function that is deprecated! |
Definitely, maybe we can plan this for 1.7.8 ? Because we will upgrade jquery to the next minor version. Dealing with these deprecations is probably not urgent for 1.7.7, and we're short on time for the 1.7.7 release... |
Fixed by #20738 |
Since upgrading jquery and adding jquery-migrate, we have many warning logs in the console:
Screenshots
Questions needing answers
Should we remove them? Should it be kept here? Should we display it but only in dev environment ? If so, how is this done following best practices ?
The text was updated successfully, but these errors were encountered: