Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "Customers > Outstanding" page #17156

Closed
31 tasks done
MatShir opened this issue Jan 14, 2020 · 2 comments · Fixed by #20288 or #27649
Closed
31 tasks done

Migrate "Customers > Outstanding" page #17156

MatShir opened this issue Jan 14, 2020 · 2 comments · Fixed by #20288 or #27649
Labels
Feature Type: New Feature migration symfony migration project PR available Solution: issue is being addressed

Comments

@MatShir
Copy link
Contributor

MatShir commented Jan 14, 2020

Part of Symfony migration project
Type: page

Enable B2B mode in Customer Setting then go to Customer to find the Oustanding page.

Check-List (copied from #13989)

App layer

Controller / routing

  • All controller actions are migrated and protected with @AdminSecurity annotations when eligible and @DemoRestricted annotations when eligible
  • All links targeting this page are updated: either using _legacy_link or updating the code
  • The new SF routes have _legacy_link and _legacy_parameters provided and explained
  • Controller catches Domain Exception and translate them nicely
  • Add/Edit controllers must catch global Exception in order to handle ModuleErrorException

Template

  • Twig templates must contain relevant blocks to allow partial extension by modules
  • Twig forms must have form_rest() and form_errors()
  • JS being used on the page can be used as enabled extensions and use a PageMap for selectors
  • Use @PrestaShop instead of PrestaShopBundle for template root path aliasing
Conventions
  • The new controller actions comply with our naming convention
  • The new SF routes names and paths comply with our naming convention
  • The new Twig template names comply actions with our naming convention
  • Created files (controller, JS assets, CSS assets and twig views) must be in the right folder following the convention
  • CSS being added must follow theme conventions

Core layer

  • Commands and Queries only use native types but internally use VOs
  • All Handlers must have an Interface
Conventions
  • The created SF service names comply with our naming convention
  • The created files must follow the folder convention (Domain, Core, Adapter...)

Polishing

  • The legacy controller and templates files are gone
  • If PR includes a new concept/mechanism, documentation must be written
  • JS and CSS assets must be compiled and up-to-date
  • License headers must be up-to-date
  • New hooks have been added to the hooks list and the SQL updates
  • Performance must be correct: page loading time, filtering/sorting/searching response time, actions response time

Testing

  • Commands and Queries are tested with Behat tests
  • Eligible Core classes are covered with unit tests*
  • Controller is covered with survival test
  • (soon) Controller is covered with E2E tests using puppeeter
  • If we break E2E tests because IDs change, we must update the E2E tests

*Eligible = easy to isolate and unit tests provide values (for example testing getters/setters is useless)

@MatShir MatShir added Feature Type: New Feature migration symfony migration project labels Jan 14, 2020
@MatShir MatShir added this to Backlog in Symfony Migration via automation Jan 14, 2020
Symfony Migration automation moved this from Backlog to Done Mar 2, 2021
@Progi1984 Progi1984 reopened this Mar 2, 2021
Symfony Migration automation moved this from Done to Hidden Mar 2, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Needs Specs Status: issue needs to be specified label Mar 2, 2021
@Progi1984
Copy link
Contributor

Progi1984 commented Feb 11, 2022

@MatShir Do you know if this issue needs to be remained opened ? I think all is done.

I checked the header multistore and it's present.

image

Ping @matks

@prestonBot prestonBot added the PR available Solution: issue is being addressed label Feb 11, 2022
@Progi1984
Copy link
Contributor

I check all points. And i fix a last point in #27649.

Symfony Migration automation moved this from Hidden to Done Feb 14, 2022
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Type: New Feature migration symfony migration project PR available Solution: issue is being addressed
Projects
3 participants