Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DeleteProductFromOrderHandler #18432

Closed
1 of 2 tasks
Progi1984 opened this issue Apr 2, 2020 · 6 comments · Fixed by #19981
Closed
1 of 2 tasks

Refactor DeleteProductFromOrderHandler #18432

Progi1984 opened this issue Apr 2, 2020 · 6 comments · Fixed by #19981
Assignees
@matthieu-rolland
Labels
1.7.7.x Branch Fixed Resolution: issue closed because fixed Refactoring Type: Refactoring
Projects
PrestaShop 1.7.7.3
Milestone
1.7.7.0

Comments

@Progi1984
Copy link
Contributor

Progi1984 commented Apr 2, 2020 •
edited

because updateOrder are nearly the same.

  • Refactor handler src/Adapter/Order/CommandHandler/DeleteProductFromOrderHandler.php for using src/Adapter/Order/Refund/OrderProductRemover.php as service.
@Progi1984 Progi1984 added Refactoring Type: Refactoring 1.7.7.x Branch labels Apr 2, 2020
@Progi1984 Progi1984 added this to Backlog in PrestaShop 1.7.7.3 via automation Apr 2, 2020
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Apr 2, 2020
@Progi1984 Progi1984 changed the title Refactor AddProductToOrderHandler & DeleteProductFromOrderHandler for updating order Refactor DeleteProductFromOrderHandler Apr 2, 2020
@Progi1984 Progi1984 mentioned this issue Apr 2, 2020
Merged
@colinegin
Copy link

Can be done after the beta has been released.

@Progi1984 Progi1984 self-assigned this Apr 8, 2020
@Progi1984 Progi1984 moved this from Backlog to To do in PrestaShop 1.7.7.3 Apr 8, 2020
@Progi1984 Progi1984 removed their assignment Apr 9, 2020
@Progi1984 Progi1984 moved this from To do to Backlog in PrestaShop 1.7.7.3 Apr 9, 2020
@Progi1984 Progi1984 mentioned this issue Apr 10, 2020
Merged
@sowbiba sowbiba assigned sowbiba and unassigned sowbiba Apr 22, 2020
@colinegin colinegin moved this from Backlog to Blocked / Need spec in PrestaShop 1.7.7.3 May 4, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Needs Specs Status: issue needs to be specified label May 4, 2020
@colinegin
Copy link

@Progi1984 could you describe the issue more in details please ?

@MatShir MatShir added the Waiting for dev Status: action required, waiting for tech feedback label May 4, 2020
@Progi1984
Copy link
Contributor Author

@colinegin It's technical for avoiding duplicate code in our codebase.

@Progi1984 Progi1984 removed Needs Specs Status: issue needs to be specified Waiting for dev Status: action required, waiting for tech feedback labels May 5, 2020
@Progi1984 Progi1984 moved this from Blocked / Need spec to Backlog in PrestaShop 1.7.7.3 May 5, 2020
@LouiseBonnard LouiseBonnard moved this from Backlog to To do in PrestaShop 1.7.7.3 May 18, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Ready Status: Issue is ready to be worked on label May 18, 2020
@matthieu-rolland matthieu-rolland self-assigned this May 19, 2020
@matthieu-rolland matthieu-rolland moved this from To do to In progress in PrestaShop 1.7.7.3 May 19, 2020
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels May 19, 2020
@matthieu-rolland matthieu-rolland mentioned this issue May 27, 2020
Closed
@matthieu-rolland matthieu-rolland moved this from In progress to To be reviewed in PrestaShop 1.7.7.3 May 27, 2020
@matthieu-rolland matthieu-rolland removed the WIP Status: Work In Progress label May 27, 2020
@matthieu-rolland matthieu-rolland moved this from To be reviewed to To do in PrestaShop 1.7.7.3 Jun 8, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Ready Status: Issue is ready to be worked on label Jun 8, 2020
@matthieu-rolland matthieu-rolland moved this from To do to In progress in PrestaShop 1.7.7.3 Jun 10, 2020
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Jun 10, 2020
@matthieu-rolland matthieu-rolland mentioned this issue Jun 11, 2020
Closed
@colinegin
Copy link

Blocked by #19646 - to be done once merged

@colinegin colinegin moved this from In progress to Blocked / Need spec in PrestaShop 1.7.7.3 Jun 24, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Needs Specs Status: issue needs to be specified label Jun 24, 2020
@matthieu-rolland matthieu-rolland moved this from Blocked / Need spec to In progress in PrestaShop 1.7.7.3 Jun 26, 2020
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Jun 26, 2020
@matthieu-rolland matthieu-rolland mentioned this issue Jun 29, 2020
Merged
@matthieu-rolland
Copy link
Contributor

This issue is treated in this PR: #19981

@Progi1984 Progi1984 linked a pull request Jul 1, 2020 that will close this issue
Refactor cancel product and bug fix #19981
Merged
PrestaShop 1.7.7.3 automation moved this from In progress to Done Jul 1, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Jul 1, 2020
@matthieu-rolland
Copy link
Contributor

Issue closed, the refactor is not was planned in this issue.

@hibatallahAouadni hibatallahAouadni removed the WIP Status: Work In Progress label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthieu-rolland matthieu-rolland

Labels
1.7.7.x Branch Fixed Resolution: issue closed because fixed Refactoring Type: Refactoring
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.0
Development

Successfully merging a pull request may close this issue.

Refactor cancel product and bug fix matthieu-rolland/PrestaShop
6 participants
@Progi1984 @matthieu-rolland @sowbiba @hibatallahAouadni @colinegin @MatShir