Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX change: have a single SAVE button at the top for BO form pages ? #21461

Open
matks opened this issue Oct 15, 2020 · 4 comments
Open

UX change: have a single SAVE button at the top for BO form pages ? #21461

matks opened this issue Oct 15, 2020 · 4 comments
Labels
Feature Type: New Feature migration symfony migration project Needs Specs Status: issue needs to be specified UX ✔️ Status: check done, design approved

Comments

@matks
Copy link
Contributor

matks commented Oct 15, 2020

Following #21460 @TristanLDD actually mentioned a new idea.

The idea would be to have, for every pages with forms, a single SAVE button at the top of the page either next to "Recommended modules" and "Help" buttons or replace them (in this case we would need to move these 2 buttons somewhere else).

Not only this single SAVE button would be easy to use, at the top, but also it would be disabled until user modifies something in the form. At this moment it would become enabled and clickable.

This however raises multiple questions:

  • Is that suitable for ALL BO pages with a form ? for example inside Taxes BO page there is a listing ; and below the listing is a small form. So when user opens the page he would see only the listing (he needs to scroll to see the form) with a SAVE button: weird
  • How does this work if, inside the page, there are 2 forms, very different, which (currently) have each their SAVE button ?
  • Technical details: how do we manage and render this button ? Do we hide the current SAVE button but it's still in the DOM, and trigger it using JS when user hits the global sticky-at-the-top SAVE button ?
@matks matks added the migration symfony migration project label Oct 15, 2020
@prestashop-issue-bot
Copy link

Thanks for opening this issue! We will help you to keep its state consistent

@MatShir MatShir added Improvement Type: Improvement Waiting for UX Status: action required, waiting for design feedback labels Oct 16, 2020
@MatShir
Copy link
Contributor

MatShir commented Oct 26, 2020

Issue #14018 that might be related to readjustment of the form

@MatShir MatShir assigned TristanLDD and unassigned TristanLDD Oct 26, 2020
@hibatallahAouadni hibatallahAouadni added the Needs Specs Status: issue needs to be specified label Dec 5, 2020
@marionf marionf added Feature Type: New Feature and removed Improvement Type: Improvement labels Dec 28, 2021
@ElodieOS
Copy link

Hi everyone! Yes, I think it's a great idea.

Actually, I'm checking all the forms to see if it's possible. If it is, the save button will be at the bottom of the screen, in a sticky position. It will be disabled if there are no changes and enabled if there are one or more changes.

I'll let you know if this issue is possible after my inventory :)

@ElodieOS
Copy link

Hi @matks
I checked all the form pages in BO and I don't see any problem to create a unique save button.

So, as I said just before, I think we can put a save button at the bottom of the screen to keep a logical flow (first you can change the settings and then you can save your actions). This button will be in sticky position to allow saving at any time (without scrolling endlessly especially when the form is big).

Two states:

  • If you have not made any changes, the save button is disabled.
    Single save button disabled

  • If you have made one or more changes, the save button becomes active.
    Single save button

Special case:

  • When you have a data table before a parameter list (like @matks said with the Taxes page for example), we don't need this mechanism because I can't find a data table with multiple parameter lists. Often you only have one parameter to change, so you can keep a "normal" save button (as is the case on the BO currently).
  • I can't find a case with two different forms in the same page. Maybe you have an example?

In terms of design :

  • Takes the whole width of the screen to make it clear that the save applies to the whole page
  • Has the same padding as the header to keep consistency and harmony
  • A border of 1 px on the top

Don't hesitate if you need more information :)

@ElodieOS ElodieOS added UX ✔️ Status: check done, design approved and removed Waiting for UX Status: action required, waiting for design feedback labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Type: New Feature migration symfony migration project Needs Specs Status: issue needs to be specified UX ✔️ Status: check done, design approved
Projects
None yet
Development

No branches or pull requests

6 participants