Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO - Orders page - increment/decrement button doesn't work when we try to add a product out of stock < 0 (allow order #21529

Closed
Tracked by #17598
khouloudbelguith opened this issue Oct 20, 2020 · 6 comments · Fixed by #21555
Assignees
Labels
1.7.7.x Branch BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed migration symfony migration project Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Nice-to-have Kanban prioritization: issue could be included in next version Order Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression
Milestone

Comments

@khouloudbelguith
Copy link
Contributor

Describe the bug

In the BO => Orders page => New Order page => when we try to add an out of stock product with allowing order, the increment/decrement button doesn't work
In this PR: #20714 we just fixed when the quantity of product = 0
But when the quantity product < 0 => NOK

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to BO => Catalog => Products page
  2. Add a product with quantity < 0 with allow order selected
  3. Go to BO => Orders => New Order page
  4. Add the last product created
  5. check the increment/decrement button
  6. see error => we can't increment the product quantity

Screenshots

https://drive.google.com/file/d/1WS2cfkW-_EVms0IPYD5FFunCpOnc6_Tz/view?usp=sharing
image

Additional information

  • PrestaShop version: 1770rc1build2
  • PHP version: 7.2
@prestashop-issue-bot
Copy link

Thanks for opening this issue! We will help you to keep its state consistent

@khouloudbelguith khouloudbelguith added 1.7.7.x Branch BO Category: Back Office Bug Type: Bug migration symfony migration project Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Order Component: Which BO section is concerned Regression Type: regression Ready Status: Issue is ready to be worked on labels Oct 20, 2020
@PululuK
Copy link
Member

PululuK commented Oct 20, 2020

Hi @khouloudbelguith
But ... you have a negative stock right ?
Thanks

@khouloudbelguith
Copy link
Contributor Author

@PululuK, yes!

If you have Allow orders as behavior when out of stock => We can have negative stock.
Steps to reproduce it for example:
Product quantity = 1 with Allow orders when out of stock
From the FO, a customer adds to the cart 3 products => checkout
In this case we have a product quantity = -2 < 0

Thanks!

@jolelievre
Copy link
Contributor

@PululuK You can configure the products to authorize to be ordered out of stock via Product::out_of_stock

@PululuK
Copy link
Member

PululuK commented Oct 20, 2020

@PululuK You can configure the products to authorize to be ordered out of stock via Product::out_of_stock

Yes I know, I misunderstood the description ... I'm sorry !

@khouloudbelguith khouloudbelguith added this to Backlog in PrestaShop 1.7.7.3 via automation Oct 20, 2020
@Progi1984 Progi1984 self-assigned this Oct 21, 2020
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Oct 21, 2020
@Progi1984 Progi1984 moved this from Backlog to To be reviewed in PrestaShop 1.7.7.3 Oct 21, 2020
@Progi1984 Progi1984 added PR available Solution: issue is being addressed and removed Ready Status: Issue is ready to be worked on labels Oct 21, 2020
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Oct 23, 2020
@marionf marionf removed this from the 1.7.7.0 milestone Oct 26, 2020
@marionf marionf added the Nice-to-have Kanban prioritization: issue could be included in next version label Oct 26, 2020
@Progi1984 Progi1984 moved this from To be tested to To be reviewed in PrestaShop 1.7.7.3 Nov 3, 2020
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Nov 3, 2020
@atomiix atomiix moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Nov 6, 2020
@khouloudbelguith khouloudbelguith added the Fixed Resolution: issue closed because fixed label Nov 11, 2020
@khouloudbelguith khouloudbelguith moved this from To be tested to To be merged in PrestaShop 1.7.7.3 Nov 11, 2020
@Progi1984
Copy link
Contributor

Fixed by #21555

PrestaShop 1.7.7.3 automation moved this from To be merged to Done Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.x Branch BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed migration symfony migration project Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Nice-to-have Kanban prioritization: issue could be included in next version Order Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants