Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockreassurance - URL not available in front office #21752

Closed
PrestaSafe opened this issue Nov 4, 2020 · 6 comments · Fixed by PrestaShop/blockreassurance#449
Closed

Blockreassurance - URL not available in front office #21752

PrestaSafe opened this issue Nov 4, 2020 · 6 comments · Fixed by PrestaShop/blockreassurance#449
Labels
Blockreassurance Module: blockreassurance Feature Type: New Feature Fixed Resolution: issue closed because fixed Module Module Modules Component: Which BO section is concerned PR available Solution: issue is being addressed

Comments

@PrestaSafe
Copy link
Contributor

PrestaSafe commented Nov 4, 2020

Describe the bug

in the module https://github.com/PrestaShop/blockreassurance v5.0.0, the URL of one element is not available in the front office and in the $elements variable, when used as a widget.

Expected behavior

Get all informations of fields available in backoffice in the front office

Steps to Reproduce

Install the module in the last version,
create one or many block reassurance elements with a link of CMS page (for exemple).

Display them on front office by using the module like a widget.

Screenshots

dump of $elementsvariable:
Capture d’écran 2020-11-04 à 17 01 41

Table ps_psreassurance:
Capture d’écran 2020-11-04 à 17 04 01

Additional information

  • PrestaShop version: 1.7.6.8
  • PHP version: 7.2
@matks
Copy link
Contributor

matks commented Nov 4, 2020

Hi @PrestaSafe I changed your issue a little because this only applies to the usecase "where the blockreassurance module v5.0.0 is used as a widget". When using regular hooks, full informations are available as Smarty variables.

I checked the code, I dont know why but indeed only few informations are built as Widget variables. For hooks full informations are provided. As it was fast to fix, I did the PR PrestaShop/blockreassurance#60

@matks
Copy link
Contributor

matks commented Nov 4, 2020

Note: it's not a bug 😛 as nothing is failing. It's rather a limitation of the module (and it will be nice to remove the limitation ^^)

@matks matks added Blockreassurance Module: blockreassurance Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Improvement Type: Improvement Modules Component: Which BO section is concerned and removed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification labels Nov 4, 2020
@hibatallahAouadni hibatallahAouadni added PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on 1.7.6.8 Affects versions labels Nov 5, 2020
@Progi1984 Progi1984 self-assigned this Nov 5, 2020
@Progi1984
Copy link
Contributor

@matks I take the issue. I discuss it with @PrestaSafe on FoP ;)

@matks
Copy link
Contributor

matks commented Nov 5, 2020

@matks I take the issue. I discuss it with @PrestaSafe on FoP ;)

All right 😉 be my guest!

You can use PR PrestaShop/blockreassurance#60 or make your own. But you'll need, like I found out, to fix blockreassurance first - it seems to fail because of Composer v2 😞

@Progi1984 Progi1984 assigned matks and unassigned Progi1984 Nov 24, 2020
@Progi1984 Progi1984 added this to To do in Native modules integration via automation Nov 24, 2020
@Progi1984 Progi1984 moved this from To do to To be tested in Native modules integration Nov 24, 2020
@Progi1984 Progi1984 removed the Ready Status: Issue is ready to be worked on label Nov 24, 2020
@matks
Copy link
Contributor

matks commented Aug 10, 2021

PR started in PrestaShop/blockreassurance#60 but I could not push it to the merge

@matks matks removed their assignment Nov 16, 2021
@hibatallahAouadni hibatallahAouadni added Ready Status: Issue is ready to be worked on and removed PR available Solution: issue is being addressed labels Dec 15, 2021
@hibatallahAouadni hibatallahAouadni moved this from To be tested to To do in Native modules integration Dec 15, 2021
@marionf marionf added Feature Type: New Feature and removed Improvement Type: Improvement labels Dec 28, 2021
@MatShir MatShir added the Module Module label Dec 28, 2021
@kpodemski kpodemski added the PR available Solution: issue is being addressed label Oct 13, 2022
@matks matks moved this from To do to To be tested in Native modules integration Nov 17, 2022
@matks
Copy link
Contributor

matks commented Nov 17, 2022

PR by @leemyongpakvn for this issue ;) PrestaShop/blockreassurance#455

@hibatallahAouadni hibatallahAouadni removed the 1.7.6.8 Affects versions label Nov 18, 2022
@florine2623 florine2623 moved this from To be tested to To be merged in Native modules integration Nov 21, 2022
@florine2623 florine2623 added the Fixed Resolution: issue closed because fixed label Nov 21, 2022
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Nov 21, 2022
Native modules integration automation moved this from To be merged to Done Nov 21, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blockreassurance Module: blockreassurance Feature Type: New Feature Fixed Resolution: issue closed because fixed Module Module Modules Component: Which BO section is concerned PR available Solution: issue is being addressed
Projects
8 participants