Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI-KIT] - BO - Order page - The Modal of updating a carrier is not well displayed #21943

Closed
khouloudbelguith opened this issue Nov 17, 2020 · 7 comments · Fixed by #21947
Closed

[UI-KIT] - BO - Order page - The Modal of updating a carrier is not well displayed #21943

khouloudbelguith opened this issue Nov 17, 2020 · 7 comments · Fixed by #21947
Assignees
@NeOMakinG
Labels
1.7.8.0 Affects versions BO Category: Back Office Bug Type: Bug Duplicate Resolution: issue closed because already reported Front-end Category: Front end Order Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification UI Kit Repo: prestashop-ui-kit
Projects
PrestaShop 1.7.8.0 Backlog Patch
Milestone
1.7.8.0

Comments

@khouloudbelguith
Copy link
Contributor

Describe the bug

In the BO > Orders > Order details page > when we try to edit a carrier, the modal is not well displayed
image

Expected behavior

It should be
image

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to BO > Orders > Order details page
  2. Click on the Carriers Tab
  3. Click on the Edit button
  4. See error

PS1.7.7.x => ok

Additional information

  • PrestaShop version: develop(1780)
  • PHP version: 7.2
@khouloudbelguith khouloudbelguith added BO Category: Back Office Bug Type: Bug develop Branch Front-end Category: Front end Order Component: Which BO section is concerned Regression Type: regression Ready Status: Issue is ready to be worked on Major Severity: major bug > https://build.prestashop.com/news/severity-classification Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification UI Kit Repo: prestashop-ui-kit and removed Major Severity: major bug > https://build.prestashop.com/news/severity-classification labels Nov 17, 2020
@khouloudbelguith khouloudbelguith mentioned this issue Nov 17, 2020
Open
22 tasks
@khouloudbelguith khouloudbelguith added this to Not ready in PrestaShop 1.7.8.0 via automation Nov 17, 2020
@NeOMakinG NeOMakinG mentioned this issue Nov 17, 2020
Merged
@NeOMakinG NeOMakinG added the PR available Solution: issue is being addressed label Nov 19, 2020
@NeOMakinG NeOMakinG self-assigned this Nov 19, 2020
@prestashop-issue-bot prestashop-issue-bot bot moved this from Not ready to To do in PrestaShop 1.7.8.0 Nov 19, 2020
@Progi1984 Progi1984 moved this from To do to To be tested in PrestaShop 1.7.8.0 Nov 19, 2020
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Nov 19, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Nov 19, 2020
@Roomsmaniia Roomsmaniia moved this from To be tested to To be merged in PrestaShop 1.7.8.0 Nov 19, 2020
PrestaShop 1.7.8.0 automation moved this from To be merged to Done Nov 19, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Nov 19, 2020
@fire2
Copy link

fire2 commented Oct 15, 2021 •
edited

This is still an issue on a fresh PrestaShop 1.7.8 install (I tried on 3 different installations). The modal is still showing incorrectly and it is impossible to put the tracking number.

Browser: Safari. It works fine in Chrome but not in Safari.
Issue should be reopened.

@NeOMakinG
Copy link

Hey @fire2, thanks for the info

@hibatallahAouadni or anyone from @PrestaShop/qa-team could test on safari and adjust the issue regarding the ending? :)

@hibatallahAouadni
Copy link
Contributor

Hello @NeOMakinG

It's true! I reproduce the issue with PS 1.7.8.0 and Safari (iPhone):

image

Reopen it as it's not fully fixed.
Thanks!

@hibatallahAouadni hibatallahAouadni added Ready Status: Issue is ready to be worked on and removed Fixed Resolution: issue closed because fixed labels Oct 19, 2021
@hibatallahAouadni hibatallahAouadni added this to Not ready in PrestaShop 1.7.8.1 via automation Oct 19, 2021
@MatShir MatShir moved this from Not ready to In progress in PrestaShop 1.7.8.1 Oct 25, 2021
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Oct 25, 2021
@hibatallahAouadni hibatallahAouadni added Ready Status: Issue is ready to be worked on and removed WIP Status: Work In Progress labels Oct 26, 2021
@hibatallahAouadni hibatallahAouadni removed this from In progress in PrestaShop 1.7.8.1 Oct 26, 2021
@hibatallahAouadni
Copy link
Contributor

hibatallahAouadni commented Oct 26, 2021 •
edited

FYI: reproduce the issue with chrome 73 & related to #22315

@hibatallahAouadni hibatallahAouadni added Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification and removed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification labels Oct 26, 2021
@fire2
Copy link

fire2 commented Jan 16, 2022

afaik this issue was fixed on 1.7.8.1 and can be closed.

@hibatallahAouadni
Copy link
Contributor

@fire2 thanks for the tip 😉
Indeed this issue has been fixed, cause I didn't encountered it with PS1782, see the attached screenshot below:

image

This issue is a duplicate of this one #22315 (as both has been fixed with the same PR).

Thanks!

@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Jan 17, 2022
@hibatallahAouadni
Copy link
Contributor

Duplicate of #22315

@hibatallahAouadni hibatallahAouadni marked this as a duplicate of #22315 Jan 17, 2022
@hibatallahAouadni hibatallahAouadni added 1.7.8.0 Affects versions Duplicate Resolution: issue closed because already reported and removed develop Branch labels Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeOMakinG NeOMakinG

Labels
1.7.8.0 Affects versions BO Category: Back Office Bug Type: Bug Duplicate Resolution: issue closed because already reported Front-end Category: Front end Order Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification UI Kit Repo: prestashop-ui-kit
Projects
No open projects
Backlog Patch
Awaiting triage
PrestaShop 1.7.8.0
  
Done
Milestone
1.7.8.0
Development

Successfully merging a pull request may close this issue.

Adjust modal position when wrong used with a form NeOMakinG/PrestaShop
5 participants
@Progi1984 @fire2 @NeOMakinG @khouloudbelguith @hibatallahAouadni