Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behat tests: Reset static cache of all object models between feature tests (clearCacheBeforeFeature) #22197

Closed
Tracked by #19701
matthieu-rolland opened this issue Dec 2, 2020 · 3 comments · Fixed by #22198
Closed
Tracked by #19701

Behat tests: Reset static cache of all object models between feature tests (clearCacheBeforeFeature) #22197

matthieu-rolland opened this issue Dec 2, 2020 · 3 comments · Fixed by #22198
Labels
1.7.7.x Branch CO Category: Core Developer Feature Developer-oriented feature Feature Type: New Feature Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed
Projects
PrestaShop 1.7.7.3
Milestone
1.7.7.1

Comments

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Dec 2, 2020 •
edited

Is your feature request related to a problem?

Sometimes, we add behat tests, it works fine, but then it fails when we execute our test amongst the other behat tests.

That's because there are some static caches from previous tests messing with the tests we added. When it happens we have to debug, find which previous test makes our test fails, it's annoying and a loss of time.

Describe the solution you'd like

The idea is to reset the static caches of ALL object models between behat feature tests instead of resetting the cache of object models one by one as we encounter problems. There are parts of the software that are not covered by behat tests yet, and these issues will happen again for sure as we migrate new pages, integrate new CQRS commands, etc...
@matthieu-rolland matthieu-rolland added this to Backlog in PrestaShop 1.7.7.3 via automation Dec 2, 2020
@matthieu-rolland matthieu-rolland added this to the 1.7.7.1 milestone Dec 2, 2020
@matthieu-rolland matthieu-rolland mentioned this issue Dec 2, 2020
Merged
@matthieu-rolland matthieu-rolland linked a pull request Dec 2, 2020 that will close this issue
Add static cache resets #22198
Merged
@matthieu-rolland matthieu-rolland moved this from Backlog to To be reviewed in PrestaShop 1.7.7.3 Dec 2, 2020
@hibatallahAouadni hibatallahAouadni added 1.7.7.x Branch CO Category: Core Developer Feature Developer-oriented feature Feature Type: New Feature Needs Specs Status: issue needs to be specified Waiting for dev Status: action required, waiting for tech feedback PR available Solution: issue is being addressed labels Dec 2, 2020
@hibatallahAouadni
Copy link
Contributor

Hello @matthieu-rolland

Thanks for your sugguestion and your PR 😅
Ping @PrestaShop/prestashop-core-developers wdyt?

@matthieu-rolland matthieu-rolland self-assigned this Dec 2, 2020
@matthieu-rolland
Copy link
Contributor Author

@hibatallahAouadni well I discussed it with @eternoendless already, and the pr is ready for review 👍

@hibatallahAouadni hibatallahAouadni added Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified Waiting for dev Status: action required, waiting for tech feedback labels Dec 2, 2020
@prestashop-issue-bot prestashop-issue-bot bot moved this from To be reviewed to To do in PrestaShop 1.7.7.3 Dec 2, 2020
@hibatallahAouadni hibatallahAouadni mentioned this issue Dec 2, 2020
Open
35 tasks
@matthieu-rolland matthieu-rolland moved this from To do to To be reviewed in PrestaShop 1.7.7.3 Dec 2, 2020
@Progi1984
Copy link
Contributor

Fixed by #22198

PrestaShop 1.7.7.3 automation moved this from To be reviewed to Done Dec 3, 2020
@prestashop-issue-bot prestashop-issue-bot bot added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.7.7.x Branch CO Category: Core Developer Feature Developer-oriented feature Feature Type: New Feature Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.1
Development

Successfully merging a pull request may close this issue.

Add static cache resets matthieu-rolland/PrestaShop
3 participants
@Progi1984 @matthieu-rolland @hibatallahAouadni