Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when viewing a order in BackOffice when the language of the order no long exists #22611

Closed
Tracked by #17598
amaurigabriel opened this issue Dec 28, 2020 · 3 comments · Fixed by #22677
Closed
Tracked by #17598
Assignees
Labels
1.7.7.0 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Languages Label: Which BO under menu is concerned Major Severity: major bug > https://build.prestashop.com/news/severity-classification Order Component: Which BO section is concerned Regression Type: regression
Milestone

Comments

@amaurigabriel
Copy link

amaurigabriel commented Dec 28, 2020

Describe the bug

Hi,
If a order has id_lang with a value that do not correspond to an existent language in a shop, I have the same error reported in #22215. This is an issue if I remove a language, e.g. Even if I do a brand new installation and remove the English language, I can no longer open any of the pre-installed orders in the BackOffice.

Expected behavior

The order should assume the default language of the shop if it's language no longer exists.

Steps to Reproduce

  1. Make a brand new installation
  2. Remove English Language
  3. Open any of the pre-installed orders

OR

  1. Install a new language
  2. Create a order with this language
  3. Remove the language
  4. Open the order in the BackOffice.

Screenshots

The same error happen if I click in this new icon of 1.7.7.
image

Additional information

  • PrestaShop version: 1.7.7
@amaurigabriel
Copy link
Author

The fix I suggested in #22215 (comment) worked well for 1.7.7 version, but I could not find these files in the repository. Probably this part of the code is already migrated and the issue may already have been fixed?

@hibatallahAouadni
Copy link
Contributor

Hello @amaurigabriel

Thanks for your issue! I managed to reproduce it only with PS1.7.7.0, see the attached screen record below:

https://drive.google.com/file/d/1lpFaymGXXVmsugRFea3yhHsvVr0fcfZU/view

I’ll add this to the debug backlog so that it’s fixed.
If you have already fixed it on your end or if you think you can do it, please do send us a pull request!

PS: it's a regression! I didn't manage to reproduce it with PS1.7.6.9

Thank you

@hibatallahAouadni hibatallahAouadni added 1.7.7.0 Affects versions BO Category: Back Office Bug Type: Bug Order Component: Which BO section is concerned Regression Type: regression Major Severity: major bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on Languages Label: Which BO under menu is concerned labels Dec 29, 2020
@marionf marionf added this to Backlog in PrestaShop 1.7.7.3 via automation Jan 5, 2021
@atomiix atomiix self-assigned this Jan 5, 2021
@atomiix atomiix moved this from Backlog to To be reviewed in PrestaShop 1.7.7.3 Jan 5, 2021
@marionf marionf added this to the 1.7.7.2 milestone Jan 8, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Feb 8, 2021
@khouloudbelguith khouloudbelguith moved this from To be tested to In progress in PrestaShop 1.7.7.3 Feb 9, 2021
@atomiix atomiix moved this from In progress to To be reviewed in PrestaShop 1.7.7.3 Feb 10, 2021
@MatShir MatShir modified the milestones: 1.7.7.2, 1.7.7.3 Feb 12, 2021
@Progi1984 Progi1984 moved this from To be reviewed to In progress in PrestaShop 1.7.7.3 Feb 16, 2021
@atomiix atomiix moved this from In progress to To be reviewed in PrestaShop 1.7.7.3 Feb 22, 2021
@Progi1984 Progi1984 moved this from To be reviewed to In progress in PrestaShop 1.7.7.3 Feb 24, 2021
@atomiix atomiix moved this from In progress to To be reviewed in PrestaShop 1.7.7.3 Mar 1, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Mar 1, 2021
@Progi1984 Progi1984 moved this from To be tested to To be reviewed in PrestaShop 1.7.7.3 Mar 4, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Mar 5, 2021
@Progi1984 Progi1984 moved this from To be tested to In progress in PrestaShop 1.7.7.3 Mar 17, 2021
@atomiix atomiix moved this from In progress to To be reviewed in PrestaShop 1.7.7.3 Mar 17, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Mar 18, 2021
@khouloudbelguith khouloudbelguith moved this from To be tested to To be merged in PrestaShop 1.7.7.3 Mar 19, 2021
@khouloudbelguith khouloudbelguith added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Mar 19, 2021
@Progi1984
Copy link
Contributor

Fixed by #22677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.0 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Languages Label: Which BO under menu is concerned Major Severity: major bug > https://build.prestashop.com/news/severity-classification Order Component: Which BO section is concerned Regression Type: regression
Projects
No open projects
7 participants