Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.7.1 Back office Shopping Cart browsing causes "Type error: Return value of CartCore::getCartPriceFromCatalog()" #22812

Closed
devonto opened this issue Jan 13, 2021 · 4 comments · Fixed by #22947
Assignees
Labels
1.7.7.1 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Regression Type: regression Shopping carts Label: Which BO under menu is concerned
Milestone

Comments

@devonto
Copy link

devonto commented Jan 13, 2021

Describe the bug

Searching and viewing shopping carts in the back office produces an "unexpected error" screen.
As previously reported yesterday on the closed report #22784

Oops... looks like an unexpected error occurred.

Type error: Return value of CartCore::getCartPriceFromCatalog() must be of the type float, null returned

[Symfony\Component\Debug\Exception\FatalThrowableError 0]

Expected behavior

Should be able to search and open shopping carts

Steps to Reproduce

Steps to reproduce the behavior:

  1. Within back office, click on Orders -> Shopping Carts
  2. Search by name for some customers
  3. Error will not always appear (may be historical order-content specific?)

Screenshots

image
image

Additional information

  • PrestaShop version: 1.7.7.1 (just upgraded)
  • PHP version: 7.3
@devonto devonto changed the title 1.7.7.1 Back office Shoppping Cart browsing causes "unexpected error" 1.7.7.1 Back office Shoppping Cart browsing causes "Type error: Return value of CartCore::getCartPriceFromCatalog()" Jan 13, 2021
@hibatallahAouadni
Copy link
Contributor

Hello @devonto

I reproduced your issue with PS1.7.4.1 upgraded to 1.7.7.1, see the attached screen record below:

https://drive.google.com/file/d/12yb3NNec-sTPrRr4fxSID-9FOYpo_ldT/view

And it's a regression cause I didn't managed to reproduce with PS1.7.4.1 upgraded to 1.7.7.1, see the attached screen record:

https://drive.google.com/file/d/1JLebQKa9Qqq2H7eIKK6ci2I2MMr2ht8h/view

While with fresh install PS1.7.7.1, I didn't manage to reproduce it too, see the attached screen record below:

https://drive.google.com/file/d/1n4Ip5D9fWo8065mLC9RZmepGBlysk11A/view

Thanks for your issue. I’ll add this to the debug backlog so that it’s fixed.
If you have already fixed it on your end or if you think you can do it, please do send us a pull request!

Thanks!

@hibatallahAouadni hibatallahAouadni added 1.7.7.1 Affects versions BO Category: Back Office Bug Type: Bug Major Severity: major bug > https://build.prestashop.com/news/severity-classification Shopping carts Label: Which BO under menu is concerned Ready Status: Issue is ready to be worked on Regression Type: regression labels Jan 13, 2021
@MatShir MatShir added this to Backlog in PrestaShop 1.7.7.3 via automation Jan 13, 2021
@matks matks changed the title 1.7.7.1 Back office Shoppping Cart browsing causes "Type error: Return value of CartCore::getCartPriceFromCatalog()" 1.7.7.1 Back office Shopping Cart browsing causes "Type error: Return value of CartCore::getCartPriceFromCatalog()" Jan 14, 2021
@MatShir MatShir moved this from Backlog to To do in PrestaShop 1.7.7.3 Jan 18, 2021
@alfred2016decanet
Copy link

Hi I have exactly same error, on multishop product, to view order details, customer etc... this is very ambarassing :(

@4ngeluxpunk
Copy link

Hello I have the same error in several stores with version 1.7.7.0 and PHP 7.3, this error is generated when in the prefix_cart table the id_currency column is 0; Rather, the cart orders should be entered the id_currency by data 1 which is the ID of the currency but enter it with 0

@atomiix atomiix self-assigned this Jan 21, 2021
@atomiix atomiix linked a pull request Jan 22, 2021 that will close this issue
@atomiix atomiix moved this from To do to To be reviewed in PrestaShop 1.7.7.3 Jan 22, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Jan 25, 2021
@Progi1984 Progi1984 added this to the 1.7.7.2 milestone Jan 25, 2021
@khouloudbelguith khouloudbelguith added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Jan 25, 2021
@khouloudbelguith khouloudbelguith moved this from To be tested to To be merged in PrestaShop 1.7.7.3 Jan 25, 2021
@Progi1984
Copy link
Contributor

Fixed by #22947

PrestaShop 1.7.7.3 automation moved this from To be merged to Done Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.1 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Regression Type: regression Shopping carts Label: Which BO under menu is concerned
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants