Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move upgrade scripts to the autoupgrade module #23240

Closed
Tracked by #25648
eternoendless opened this issue Feb 12, 2021 · 2 comments · Fixed by PrestaShop/autoupgrade#395 or #25794
Closed
Tracked by #25648

Move upgrade scripts to the autoupgrade module #23240

eternoendless opened this issue Feb 12, 2021 · 2 comments · Fixed by PrestaShop/autoupgrade#395 or #25794
Assignees
@PierreRambaud
Labels
Autoupgrade Module: autoupgrade CO Category: Core Fixed Resolution: issue closed because fixed Improvement Type: Improvement Must-have Kanban prioritization: issue must be included in next version PR available Solution: issue is being addressed
Projects
PrestaShop 8.0.0
Milestone
8.0.0

Comments

@eternoendless
Copy link
Member

Is your feature request related to a problem?

  • The Core shouldn't be aware of the upgrade process.
  • Putting the incremental upgrade scripts (SQL, PHP) in the core means that fixing them requires a new release.

Describe the solution you'd like

Everything related to upgrade should be removed from the core and handled by the module itself.

Additional context

This might require the module to stop behaving like a module, at least during the upgrade process.
@eternoendless eternoendless added Improvement Type: Improvement Autoupgrade Module: autoupgrade labels Feb 12, 2021
@eternoendless eternoendless added this to Not ready in PrestaShop 8.0.0 via automation Feb 12, 2021
@eternoendless eternoendless mentioned this issue Feb 12, 2021
Open
3 tasks
@hibatallahAouadni hibatallahAouadni added CO Category: Core Needs Specs Status: issue needs to be specified labels Feb 12, 2021
@PierreRambaud PierreRambaud self-assigned this Jun 21, 2021
@Progi1984 Progi1984 moved this from Not ready to To do in PrestaShop 8.0.0 Jun 21, 2021
@PierreRambaud PierreRambaud mentioned this issue Jun 23, 2021
Merged
@hibatallahAouadni hibatallahAouadni added PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified labels Jul 14, 2021
@Progi1984 Progi1984 moved this from To do to To be tested in PrestaShop 8.0.0 Jul 26, 2021
@sarahdib sarahdib moved this from To be tested to To be merged in PrestaShop 8.0.0 Jul 26, 2021
PrestaShop 8.0.0 automation moved this from To be merged to Done Jul 26, 2021
@prestashop-issue-bot prestashop-issue-bot bot removed Ready Status: Issue is ready to be worked on labels Jul 26, 2021
@Progi1984 Progi1984 reopened this Jul 26, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Needs Specs Status: issue needs to be specified label Jul 26, 2021
@Progi1984 Progi1984 moved this from Done to In progress in PrestaShop 8.0.0 Jul 26, 2021
@Progi1984
Copy link
Contributor

@PierreRambaud PrestaShop/autoupgrade#395 is merged.

@marionf marionf added Must-have Kanban prioritization: issue must be included in next version and removed Needs Specs Status: issue needs to be specified labels Jul 26, 2021
@marionf marionf closed this as completed Jul 26, 2021
PrestaShop 8.0.0 automation moved this from In progress to Done Jul 26, 2021
@marionf marionf added the Fixed Resolution: issue closed because fixed label Jul 26, 2021
@Progi1984 Progi1984 reopened this Jul 28, 2021
@prestashop-issue-bot prestashop-issue-bot bot added Needs Specs Status: issue needs to be specified and removed Fixed Resolution: issue closed because fixed labels Jul 28, 2021
@Progi1984
Copy link
Contributor

@marionf I reopened because scripts have not been removed in Core. They are just moved in autoupgrade.

@Progi1984 Progi1984 moved this from Done to In progress in PrestaShop 8.0.0 Jul 28, 2021
@Progi1984 Progi1984 added this to the 8.0.0 milestone Jul 28, 2021
@marionf marionf moved this from In progress to To do in PrestaShop 8.0.0 Aug 2, 2021
@Progi1984 Progi1984 moved this from To do to In progress in PrestaShop 8.0.0 Aug 5, 2021
@marionf marionf mentioned this issue Aug 19, 2021
Open
59 tasks
@PierreRambaud PierreRambaud mentioned this issue Sep 6, 2021
Merged
@Progi1984 Progi1984 moved this from In progress to To be reviewed in PrestaShop 8.0.0 Sep 6, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 8.0.0 Sep 7, 2021
@khouloudbelguith khouloudbelguith moved this from To be tested to To be reviewed in PrestaShop 8.0.0 Sep 28, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 8.0.0 Oct 25, 2021
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Oct 25, 2021
PrestaShop 8.0.0 automation moved this from To be tested to Done Oct 26, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierreRambaud PierreRambaud

Labels
Autoupgrade Module: autoupgrade CO Category: Core Fixed Resolution: issue closed because fixed Improvement Type: Improvement Must-have Kanban prioritization: issue must be included in next version PR available Solution: issue is being addressed
Projects
No open projects
PrestaShop 8.0.0
  
Done
Milestone
8.0.0
5 participants
@eternoendless @PierreRambaud @Progi1984 @marionf @hibatallahAouadni