Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to precisely inform about PHP compatibility when installing or using Prestashop? #23551

Open
jeckyl opened this issue Mar 7, 2021 · 9 comments
Labels
Feature Type: New Feature IN Category: Install Needs Specs Status: issue needs to be specified Waiting for PM Status: action required, waiting for product feedback

Comments

@jeckyl
Copy link
Contributor

jeckyl commented Mar 7, 2021

Is your feature request related to a problem?

The French community must have exceeded the ten thousand times to repeat and remind the PHP version compatibility range for version 1.7 of PrestaShop, which means that people can install PrestaShop on servers not offering the right version of PHP or with hosters forcing the use of bad versions of PHP.

Describe the solution you'd like

It would certainly be enough to test the PHP version and to add a precise warning indicating that the PHP version currently in use does not guarantee optimal operation and may cause malfunctions.

Alternatives you've considered

Block the installation if the PHP version is not the right one.

@matks
Copy link
Contributor

matks commented Mar 8, 2021

Hi @jeckyl I think this issue is somehow similar to #20842 which has been fixed in develop through #20843 what do you think?

@jeckyl
Copy link
Contributor Author

jeckyl commented Mar 8, 2021

This correction brings a solution during installation.
On the other hand it does not seem to support information for users who install locally or when their host changes their PHP version.

@hibatallahAouadni
Copy link
Contributor

Hello @jeckyl

Thanks for the suggestion, the Product Team will take a look.
Please stay tuned !

Ping @PrestaShop/product-team , what do you think?

@hibatallahAouadni hibatallahAouadni added Improvement Type: Improvement IN Category: Install Needs Specs Status: issue needs to be specified Waiting for PM Status: action required, waiting for product feedback labels Mar 8, 2021
@marionf marionf added Feature Type: New Feature and removed Improvement Type: Improvement labels Dec 28, 2021
@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 25, 2023

@matks @kpodemski I will check if wrong PHP version is reported in the Information section, if not, we could do it.

But, I think that checking the version on runtime and showing some big error box is an overkill. WDYT?

@matks
Copy link
Contributor

matks commented Jul 26, 2023

But, I think that checking the version on runtime and showing some big error box is an overkill. WDYT?

I'm not sure it's gonna work 😄

Consider the following scenario:

  • Jack installs PS 1.7.8.9 on PHP7.4
  • Then Jack sees PHP7.4 is EOL and upgrades PHP to 8.2 (or the hosting provides forces the switch to PHP 8.2)

I think @jeckyl would like that a big RED warning messages appears in PS and tells users "Hey! Hey! We have detected you are running PS with a PHP version that is not supported! "

But what is also likely to happen is... when Jack browses his backoffice, he will simply have a blank page 😅 because PHP8.2 on PS 1.7.8.9 I'm quite sur it crashes. You can't display an error message if it just does not even run...

So we can add some infos (warning, info section ...) but keep in mind we have no guarantee PrestaShop will even succeed to display them

@MatShir
Copy link
Contributor

MatShir commented Jul 26, 2023

Isn't the check already done on the installation ? 🤔
Anyway, it would be nice to display it on info page and also add small warning on dashboard (it well help merchant with an operating BO)

@kpodemski
Copy link
Contributor

@MatShir I believe it is, and @matks is right about switching PHP version :) I think we can close this issue as completed :)

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 27, 2023

I think this is unnecessary logic and a extra runtime check. I would close it if @MatShir and @kpodemski agree.

@MatShir
Copy link
Contributor

MatShir commented Aug 23, 2023

The check is done on the information page, we could highlight it there when the version is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Type: New Feature IN Category: Install Needs Specs Status: issue needs to be specified Waiting for PM Status: action required, waiting for product feedback
Projects
None yet
Development

No branches or pull requests

7 participants