Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using delete request in back office #24209

Closed
sarahdib opened this issue Apr 26, 2021 · 3 comments · Fixed by #24217
Closed

Error when using delete request in back office #24209

sarahdib opened this issue Apr 26, 2021 · 3 comments · Fixed by #24217
Assignees
@PierreRambaud
Labels
1.7.6.0 Affects versions 1.7.6.9 Affects versions BO Category: Back Office Bug Type: Bug Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification Database Label: Which BO under menu is concerned Fixed Resolution: issue closed because fixed migration symfony migration project PR available Solution: issue is being addressed Regression Type: regression
Projects
PrestaShop 1.7.7.5
Milestone
1.7.7.5

Comments

@sarahdib
Copy link
Contributor

sarahdib commented Apr 26, 2021 •
edited by marionf

Describe the bug

Error when using delete request in back office

Expected behavior

It shouldn't be possible to delete something using sql manager in back office

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to admin -> database (with mode debug off)
  2. Add a sql request using delete and save
  3. Execute this request
  4. See error and check in database that the request is executed.
  1. Go to admin -> database (with mode debug on)
  2. Add a sql request using delete and save
  3. Execute this request
  4. See error and check in database that the request isn't executed.

Before the migration it wasn't possible to save delete request.

Screenshots

Before migration (<1.7.6.0) : https://drive.google.com/file/d/1QY8vPiWKlDbHPiwScdxyPk7ztL4Uoe-a/view
After migration (>1.7.6.0) : https://drive.google.com/file/d/17PTrAf2gqiM7dyQ_x1gJScsVrZXW44nZ/view

Additional information

  • PrestaShop version: 1.7.6.9, 1.7.7.3, 1.7.8.x, develop
  • PHP version: 7.1
@sarahdib sarahdib added 1.7.6.9 Affects versions Bug Type: Bug 1.7.7.3 Affects versions 1.7.8.x Branch migration symfony migration project develop Branch Ready Status: Issue is ready to be worked on labels Apr 26, 2021
@hibatallahAouadni hibatallahAouadni added BO Category: Back Office Database Label: Which BO under menu is concerned labels Apr 26, 2021
@sarahdib sarahdib added the Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification label Apr 26, 2021
@hibatallahAouadni hibatallahAouadni added this to Backlog in Symfony Migration via automation Apr 26, 2021
@marionf marionf added this to Backlog in PrestaShop 1.7.7.4 via automation Apr 26, 2021
@marionf
Copy link
Contributor

marionf commented Apr 26, 2021

@sarahdib I am not sure about the critical severity here, if it's critical it means we should fix it in 1.7.7.4

@marionf marionf added 1.7.6.0 Affects versions Regression Type: regression and removed 1.7.7.3 Affects versions 1.7.8.x Branch develop Branch labels Apr 26, 2021
@MatShir MatShir moved this from Backlog to To do in Symfony Migration Apr 26, 2021
@MatShir MatShir moved this from Backlog to To do in PrestaShop 1.7.7.4 Apr 26, 2021
@PierreRambaud PierreRambaud mentioned this issue Apr 26, 2021
Merged
@PierreRambaud PierreRambaud moved this from To do to To be reviewed in PrestaShop 1.7.7.4 Apr 26, 2021
@sowbiba sowbiba moved this from To be reviewed to In progress in PrestaShop 1.7.7.4 Apr 27, 2021
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Apr 27, 2021
@marionf marionf removed this from To do in Symfony Migration Apr 27, 2021
@PierreRambaud PierreRambaud moved this from In progress to To be reviewed in PrestaShop 1.7.7.4 Apr 28, 2021
@Progi1984 Progi1984 removed this from To be reviewed in PrestaShop 1.7.7.4 Apr 28, 2021
@Progi1984 Progi1984 added this to To be reviewed in PrestaShop 1.7.7.5 Apr 28, 2021
@Progi1984 Progi1984 linked a pull request Apr 28, 2021 that will close this issue
Restore check when using the SQL manager part #24217
Merged
@Progi1984 Progi1984 moved this from To be reviewed to In progress in PrestaShop 1.7.7.5 May 7, 2021
@Progi1984 Progi1984 moved this from In progress to To be tested in PrestaShop 1.7.7.5 May 12, 2021
@Progi1984 Progi1984 added this to the 1.7.7.5 milestone May 12, 2021
@hibatallahAouadni hibatallahAouadni added the PR available Solution: issue is being addressed label May 12, 2021
@sarahdib sarahdib moved this from To be tested to To be merged in PrestaShop 1.7.7.5 May 12, 2021
@PierreRambaud
Copy link
Contributor

FYI, the main problem was about it was allowed to create request other than a SELECT.
Before the migration you were only able to execute SELECT as it is defined in the notice inside the page. I restore the normal behaviour.

@Progi1984
Copy link
Contributor

Fixed by @PierreRambaud in #24217

PrestaShop 1.7.7.5 automation moved this from To be merged to Done May 12, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label May 12, 2021
@marionf marionf removed the WIP Status: Work In Progress label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierreRambaud PierreRambaud

Labels
1.7.6.0 Affects versions 1.7.6.9 Affects versions BO Category: Back Office Bug Type: Bug Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification Database Label: Which BO under menu is concerned Fixed Resolution: issue closed because fixed migration symfony migration project PR available Solution: issue is being addressed Regression Type: regression
Projects
No open projects
PrestaShop 1.7.7.5
Done
Milestone
1.7.7.5
Development

Successfully merging a pull request may close this issue.

Restore check when using the SQL manager part
5 participants
@PierreRambaud @Progi1984 @sarahdib @marionf @hibatallahAouadni