Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order messages not in customers languages 1.7.7.3 #24499

Closed
01park opened this issue May 14, 2021 · 9 comments · Fixed by #25059
Closed

Order messages not in customers languages 1.7.7.3 #24499

01park opened this issue May 14, 2021 · 9 comments · Fixed by #25059
Assignees
@Progi1984
Labels
1.7.7.3 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Order messages Label: Which BO under menu is concerned Order Component: Which BO section is concerned PM ✔️ Status: check done, behavior approved PR available Solution: issue is being addressed Regression Type: regression Translations Label: Which BO under menu is concerned
Projects
PrestaShop 1.7.7.7
Milestone
1.7.7.6

Comments

@01park
Copy link

01park commented May 14, 2021 •
edited by hibatallahAouadni

Describe the bug

Since we migrated from 1.7.6 to 1.7.7.3 sending order messages to customer are always in English, even when the customer has a selected a different language.
At first I thought, maybe something was wrongly imported during the migration, but when I deleted a order message and created a new one, also the new message is in default English in our case.

Expected behavior

I would like that the order messages are send in the customers language

image

Steps to reproduce

  1. We have a site with multiple languages.
  2. FO > change your language to Arabic (for exemple)
  3. Create an Order
  4. BO > SELL > Orders > Edit last Order
  5. try to send the delay message
  6. See error, the delay message is with Admin language (English) and not Client language (Arabic)

Reproduce by having multiple language messages and customers.

Additional information

  • PrestaShop version: 1.7.7.3
  • PHP version: 7.2
@florine2623
Copy link
Contributor

Hello @01park ,

Can you specify the languages available on your site ? And what is the default language ?

Thanks!

@florine2623 florine2623 added 1.7.7.3 Affects versions Email Label: Which BO under menu is concerned NMI Status: issue needs more information Translations Label: Which BO under menu is concerned Bug Type: Bug labels May 14, 2021
@01park
Copy link
Author

01park commented May 14, 2021

Hi @florine2623

Our backoffice language is English and front office has English, Spanish, Germany, Dutch, Italian, French and more.

@hibatallahAouadni
Copy link
Contributor

Hello @01park

Thanks for your feedback!
Could you please provide clear and concise steps to reproduce the issue.

Thanks!

@01park
Copy link
Author

01park commented Jun 3, 2021 •
edited

Hi,

We have a site with multiple languages. The order messages are translated into the specific language. No matter what language the customer selects, the back office always selects the default languages English to reply to their message.

Reproduce by having multiple language messages and customers.

Update:

I updated a second store to 1.7.7.4 and also this store has the same issue. Could it be Multi-store related?

@hibatallahAouadni hibatallahAouadni added Order messages Label: Which BO under menu is concerned CO Category: Core BO Category: Back Office and removed CO Category: Core Email Label: Which BO under menu is concerned labels Jun 9, 2021
@hibatallahAouadni
Copy link
Contributor

Hello @01park

Thanks for your issue! Yes I reproduce the issue, but I think we never work on this.
So, ping @PrestaShop/product-team wdyt? is better to treat this issue as a bug or as an improvement? if as an improvement, I suggest we add this language select in Order page:

image

Wdyt?

@hibatallahAouadni hibatallahAouadni added Needs Specs Status: issue needs to be specified Waiting for PM Status: action required, waiting for product feedback and removed NMI Status: issue needs more information labels Jun 10, 2021
@01park
Copy link
Author

01park commented Jun 13, 2021

Hi,

I would like it to be just like in previous PS version, that the language is selected automatic based on customers language. Adding is box is an option, but the you would still need to know the language the customer speaks.

@hibatallahAouadni
Copy link
Contributor

Related to #10258

@hibatallahAouadni hibatallahAouadni added the Order Component: Which BO section is concerned label Jun 17, 2021
@MatShir MatShir added this to Backlog in PrestaShop 1.7.7.7 via automation Jun 17, 2021
@MatShir MatShir added the Regression Type: regression label Jun 17, 2021
@Progi1984 Progi1984 moved this from Backlog to Blocked / Need spec in PrestaShop 1.7.7.7 Jun 18, 2021
@MatShir MatShir added PM ✔️ Status: check done, behavior approved and removed Waiting for PM Status: action required, waiting for product feedback labels Jun 21, 2021
@MatShir MatShir moved this from Blocked / Need spec to To do in PrestaShop 1.7.7.7 Jun 21, 2021
@hibatallahAouadni hibatallahAouadni added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified labels Jun 21, 2021
@Progi1984 Progi1984 self-assigned this Jun 21, 2021
@Progi1984 Progi1984 moved this from To do to In progress in PrestaShop 1.7.7.7 Jun 21, 2021
@Progi1984 Progi1984 mentioned this issue Jun 21, 2021
Merged
@Progi1984 Progi1984 linked a pull request Jun 21, 2021 that will close this issue
Fixed translated order messages in Order View #25059
Merged
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jun 21, 2021
@Progi1984 Progi1984 moved this from In progress to To be reviewed in PrestaShop 1.7.7.7 Jun 21, 2021
@Progi1984 Progi1984 added this to the 1.7.7.6 milestone Jun 21, 2021
@sowbiba sowbiba moved this from To be reviewed to To be tested in PrestaShop 1.7.7.7 Jun 24, 2021
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Jun 24, 2021
@hibatallahAouadni hibatallahAouadni added the Fixed Resolution: issue closed because fixed label Jun 24, 2021
@hibatallahAouadni hibatallahAouadni moved this from To be tested to To be merged in PrestaShop 1.7.7.7 Jun 24, 2021
@hibatallahAouadni
Copy link
Contributor

FYI: I reproduce the same issue with PS1.7.8.0 and 1.7.8.x

@Progi1984
Copy link
Contributor

Fixed in #25059 by @Progi1984

PrestaShop 1.7.7.7 automation moved this from To be merged to Done Jul 8, 2021
@matks matks mentioned this issue Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Progi1984 Progi1984

Labels
1.7.7.3 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Order messages Label: Which BO under menu is concerned Order Component: Which BO section is concerned PM ✔️ Status: check done, behavior approved PR available Solution: issue is being addressed Regression Type: regression Translations Label: Which BO under menu is concerned
Projects
No open projects
PrestaShop 1.7.7.7
Done
Milestone
1.7.7.6
Development

Successfully merging a pull request may close this issue.

Fixed translated order messages in Order View Progi1984/PrestaShop
6 participants
@Progi1984 @florine2623 @prestonBot @hibatallahAouadni @MatShir @01park