Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brands are shown wrongly in the FO #25214

Closed
PeNov opened this issue Jul 2, 2021 · 2 comments · Fixed by #25216
Closed

Brands are shown wrongly in the FO #25214

PeNov opened this issue Jul 2, 2021 · 2 comments · Fixed by #25216
Labels
1.7.7.4 Affects versions 1.7.7.5 Affects versions Brands Label: Which BO under menu is concerned Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed Regression Type: regression
Milestone

Comments

@PeNov
Copy link

PeNov commented Jul 2, 2021

Describe the bug

Brands with description and links are shown wrongly in the FO. Links are not available.

Example:
1) Brand without description:
BO:
image
FO:
image
Logo, Link: Fashion manufactured have link: domain.com/1_fashion-manufacturer - This is correct behavior.

2) Brand with description:
BO:
image
link 1 (Link to the product 1): domain.com/tshirts/1-1-faded-short-sleeves-tshirt.html#/1-velikost-s/13-barva-oranzova
link 2 (Product 2): domain.com/summer-dresses/7-printed-chiffon-dress.html
Inserted code:
<p>Text Text Text Text Text Text Text Text Text Text Text for example: <a href="https://domain.com/tshirts/1-1-faded-short-sleeves-tshirt.html#/1-velikost-s/13-barva-oranzova">Link to the product 1</a> and <a href="https://domain.com/summer-dresses/7-printed-chiffon-dress.html">Product 2</a></p>

FO:
image
Logo, text Fasion Manufacturer contain link to domain.com/summer-dresses/7-printed-chiffon-dress.html (last link in the description) - this is wrong!

Correct link is domain.com/1_fashion-manufacturer

Second problem is Links to the product 1 and Product 2 are not available/clickable. There is last url from description: domain.com/summer-dresses/7-printed-chiffon-dress.html

Thank you
Best regards
PN

Additional information

  • PrestaShop version: 1.7.7.4
  • PHP version: 7.3.27-1~deb10u1
@khouloudbelguith
Copy link
Contributor

Hi @PeNov,

Thanks for your report.
I was able to reproduce the issue with PrestaShop version 1.7.7.5.
In fact, links are ok, but they are not clickable
image
It seems related to this PR: #16857

With PS1765 => ok
image

I'll add this to the debug backlog so that it's fixed.
Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project's own time, we strongly suggest you consider hiring a specialist to help you.
If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you!

@khouloudbelguith khouloudbelguith added 1.7.7.4 Affects versions 1.7.7.5 Affects versions Brands Label: Which BO under menu is concerned Bug Type: Bug FO Category: Front Office Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression Ready Status: Issue is ready to be worked on labels Jul 2, 2021
@khouloudbelguith khouloudbelguith added this to Backlog in PrestaShop 1.7.7.7 via automation Jul 2, 2021
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jul 2, 2021
@prestashop-issue-bot prestashop-issue-bot bot moved this from Backlog to To do in PrestaShop 1.7.7.7 Jul 2, 2021
@NeOMakinG NeOMakinG moved this from To do to To be reviewed in PrestaShop 1.7.7.7 Jul 5, 2021
@Progi1984 Progi1984 linked a pull request Jul 5, 2021 that will close this issue
@Progi1984 Progi1984 added this to the 1.7.7.6 milestone Jul 5, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.7.7 Jul 8, 2021
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Jul 8, 2021
@Progi1984
Copy link
Contributor

Fixed in #25216 by @NeOMakinG

PrestaShop 1.7.7.7 automation moved this from To be tested to Done Jul 8, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.4 Affects versions 1.7.7.5 Affects versions Brands Label: Which BO under menu is concerned Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed Regression Type: regression
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants