Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO responsivity - button text should not overflow #25422

Closed
Hlavtox opened this issue Jul 26, 2021 · 4 comments · Fixed by PrestaShop/prestashop-ui-kit#167
Closed

BO responsivity - button text should not overflow #25422

Hlavtox opened this issue Jul 26, 2021 · 4 comments · Fixed by PrestaShop/prestashop-ui-kit#167
Assignees
Labels
1.7.8.x Branch BO Category: Back Office Bug Type: Bug develop Branch Fixed Resolution: issue closed because fixed Front-end Category: Front end PR available Solution: issue is being addressed Regression Type: regression Responsive Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification
Milestone

Comments

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 26, 2021

Describe the bug

Longer buttons overflow their container on lower resolutions.

Expected behavior

They should wrap

Steps to reproduce

  1. BO > Edit your Profile
  2. Change your admin language to Čeština (Czech)
  3. Save
  4. Go to Orders > Invoices
  5. On your browser, enable the Toggle device toolbar
  6. Choose iPhone 5s view
  7. See error

How to fix it

Remove white-space: nowrap; from buttons.

Screenshots

buttons

Additional information

  • PrestaShop version: develop & 1.7.8.x
@hibatallahAouadni
Copy link
Contributor

Hello @Hlavtox

Thanks for your issue! I reproduce the issue with develop and 178x. It's a regression! cause I didn't manage to reproduce it with PS1775, see the attached screenshot below:

image

I think it's caused when we add the padding-right and padding-left to the content-div.
I’ll add this to the debug backlog so that it’s fixed.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

@hibatallahAouadni hibatallahAouadni added 1.7.8.x Branch BO Category: Back Office Bug Type: Bug develop Branch Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression Responsive Ready Status: Issue is ready to be worked on labels Jul 26, 2021
@hibatallahAouadni hibatallahAouadni added this to Not ready in PrestaShop 1.7.8.0 via automation Jul 26, 2021
@hibatallahAouadni hibatallahAouadni moved this from Not ready to To do in PrestaShop 1.7.8.0 Jul 26, 2021
@hibatallahAouadni hibatallahAouadni added Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification and removed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification labels Jul 26, 2021
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 26, 2021

@hibatallahAouadni No it's caused by what I said :-) The button should be allowed to wrap. It should always fit no matter the outside container.

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 26, 2021

@hibatallahAouadni This is standard behavior in Boostrap 4, so we need to override it. It's removed in Boostrap 5, I think they found out the same as we did. 👍

@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jul 26, 2021
@hibatallahAouadni
Copy link
Contributor

hibatallahAouadni commented Jul 26, 2021

@Hlavtox yep I know 😉 I meant that the issue appears now cause we changed the paddings
Thanks for your PR 🚀

@hibatallahAouadni hibatallahAouadni added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Jul 27, 2021
@hibatallahAouadni hibatallahAouadni moved this from To do to To be reviewed in PrestaShop 1.7.8.0 Jul 27, 2021
@hibatallahAouadni hibatallahAouadni removed the WIP Status: Work In Progress label Jul 28, 2021
@marionf marionf added this to the 1.7.8.1 milestone Jul 30, 2021
@marionf marionf removed this from To be reviewed in PrestaShop 1.7.8.0 Jul 30, 2021
@marionf marionf added this to Not ready in PrestaShop 1.7.8.1 via automation Jul 30, 2021
@marionf marionf moved this from Not ready to To be reviewed in PrestaShop 1.7.8.1 Jul 30, 2021
@Progi1984 Progi1984 moved this from To be reviewed to To be tested in PrestaShop 1.7.8.1 Aug 10, 2021
@Hlavtox Hlavtox changed the title BO responsivity - button should be allowed to overflow BO responsivity - button text should not overflow Aug 12, 2021
PrestaShop 1.7.8.1 automation moved this from To be tested to Done Sep 22, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.x Branch BO Category: Back Office Bug Type: Bug develop Branch Fixed Resolution: issue closed because fixed Front-end Category: Front end PR available Solution: issue is being addressed Regression Type: regression Responsive Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification
Projects
No open projects
4 participants