SVG usage in blockreassurance is broken

[matks]

Describe the bug

Blockreassurance blocks crash on FO when using an SVG icon and __PS_BASE_URI__ is a slash

Expected behavior

No crash, correct behavior and display of blockreassurrance blocks on FO

Steps to Reproduce

Steps to reproduce the behavior:

1. You use blockreassurance v5.0.0 and __PS_BASE_URI__ is a single slash / (default situation)
2. Click on 'configure' for blockreassurance module, edit one block
3. Upload a custom icon: use a SVG file
4. Open FO product page, see error Warning: finfo_file(...): failed to open stream: No such file or directory

Screenshots

As mentioned by @matthieumota in PR PrestaShop/blockreassurance#210 when __PS_BASE_URI__ is a / the str_replace() replace all slashes by project directory. This is the source of the bug.

Additional information

• PrestaShop version: 1.7.8.x
• PHP version: 7.4

[matks]

PR available PrestaShop/blockreassurance#210

[hibatallahAouadni]

Hello @matks

This issue reminds me of this one #15939 whose already fixed by this PR PrestaShop/blockreassurance#35
Is it related?

Thanks!

[matks]

No, it is different. PR PrestaShop/blockreassurance#35 enabled the use of SVG but contained a little mistake. This mistake introduced a bug, this is the bug being reported here. PR PrestaShop/blockreassurance#210 fixes this bug, so you could say PrestaShop/blockreassurance#210 is "part 2" of PrestaShop/blockreassurance#35

[hibatallahAouadni]

Well then, thanks for reporting the issue 😉

[olecorre]

I have the same problem on a new installation, I had to apply the patch

[matks]

Looks similar to #28264

[hibatallahAouadni]

@matks so should I close it as a duplicate?

[matks]

@hibatallahAouadni #28264 is being fixed so I suggest we wait for #28264 then we verify if this one is still present.