BO - Products page - an exception is displayed when combination feature is disabled

[dmoibm]

Describe the bug

After the update from 1.7.7.5 to 1.7.7.7 the error 'Undefined index: attribute_price' appears.

Steps to Reproduce

Steps to reproduce the behavior:

1. Enable debug mode
2. Delete all products with combinations
3. Go to BO > Advanced Parameters > Performance page
4. Disable Combination
5. Go to BO > Catalog > Products page
6. See an error
   

It is ok with PS1775

---

It fails on line 3418 (1.7.7.7) in Product.php.
'attribute_price' => $row['attribute_price'] ?: null,

Bevore line 3408 (1.7.7.5) there was this code that works:
'attribute_price' => (isset($row['attribute_price']) ? $row['attribute_price'] : null),

It fails only if the feature Combination is disabled.

I don't understand because this code works in the same environment:

$array2 = [
    "foo" => "bar",
    "bar" => "foo",
];

echo $array2['foos'] ?: "gugus";

• PrestaShop version: 1.7.7.7
• PHP version: 7.2.24 on Ubuntu

[khouloudbelguith]

Hi @dmoibm,

Thanks for you report.
Unfortunately, there is not enough information provided to reproduce it and work on it. You must follow the template to submit a complete bug report.
Read more about how we expect the issues to be handled here.

Thanks to edit your first comment.

[kpodemski]

Thank you @dmoibm

You're right, this check is invalid.

@khouloudbelguith it's more like a dev report but he's right and it's indeed a bug 👍

Edit: also, it's a regression

[khouloudbelguith]

Thanks @kpodemski, I updated the first comment.
It is a regression from PS1776.

I’ll add this to the debug roadmap.

Thanks!

[matks]

Fixed by #25784