FO - Cart Rule error with multi-conditions

[daniel-imax]

Describe the bug

This issue is related to this ticket: #15525
There are an unexpected behavior when you create a cart rule and add multiples rules within the same product selection.

Expected behavior

According with the docs, all the rules within the same product selection must be true to the rule be applyed.

Steps to Reproduce

Steps to reproduce the behavior:

1- Create a new Cart rule
2- Add a new product restriction
3- Inside this product restriction choose products. All products except the products of one manufacturer
4- Add manufacturer restriction and choose the manufacturer which products you didnt selected before
5- Select on "Actions" the Selected products option
6- On the front end, add a product from the choosen products list and another of the choosen manufacturer to the cart.
7- Add the cart rule created to the cart.
8- As the conditions are impossible, it shouldnt let you add the voucher, but it is added and the amount calculated on one of the products.

Screenshots

Additional information

• PrestaShop version: 1.7.7.5
• PHP version: N/A

[khouloudbelguith]

Hi @daniel-imax,

Thanks for your report.
I did not manage to reproduce the issue with PS1.7.8.0.
I attached a screen record
https://watch.screencastify.com/v/QIeipMZ24CmYJHmfx78E

Could you please check in the FO > Sitemap > Brand_name => your product is well displayed in the list
Could you please check in the BO > Cart rule > Product selection => the other product is well displayed in the selected list.

Thanks!

[daniel-imax]

Hello, your video shows exactly the wrong behaviour,
Product Brand1 -> is not in the selected product list but is in the selected brand list
Product Customizable mug -> is in the selected product list but its manufacturer is not in the selected brand list

As the documentation said, both rules must be fullfiled to allow to use the cart rule, but neither product fullfill both rules.
And if the doc are wrong and only one rule is enough, why the rule you show only reduct the 10% of a product (Brand 1 in this case). It should reduct on both products

I mean, if the rules on the same product selection are joined with an "AND" the rules cant be applied, and if are joinned with an "OR" both products must have the discount

[khouloudbelguith]

@daniel-imax, thanks for your feedback.
I think your issue is similar to this ticket: #15525
Can you please confirm?

Thanks!

[daniel-imax]

@khouloudbelguith, thanks for your fast replay. It seems is just the opposite. The first thing i need to know what is correct, the label "The product(s) are matching one of these" or the docs.
If the lable is correct (checking the code it seems is not), the bug is the amount discounted, and if you create the same rules but on separate "product selections" the behaivour is wrong too (if the label is correct)

[khouloudbelguith]

@daniel-imax, thanks for your feedback.
I manage to reproduce the issue with PS1778 and PS1780

I'll add this to the debug backlog so that it's fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project's own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thanks!