Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FO] Quantity touchspin can break and buttons are too small #26641

Open
2 tasks done
SharakPL opened this issue Nov 17, 2021 · 6 comments
Open
2 tasks done

[FO] Quantity touchspin can break and buttons are too small #26641

SharakPL opened this issue Nov 17, 2021 · 6 comments
Labels
8.1.x Branch Bug Type: Bug FO Category: Front Office Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified Old Products Page Concerns the old product page Shopping carts FO All the issues related to the Front Office Shopping Cart Verified The issue has been reproduced

Comments

@SharakPL
Copy link
Contributor

SharakPL commented Nov 17, 2021

Prerequisites

Describe the bug and add screenshots

  1. Quantity touchspin can brake on product page, product quick view on the list and cart summary.
  2. More/less buttons are definitely too small, especially on mobile. Recommended size for any button to be usable on mobile is 40+ pixels. These ones have only 23-24 px, so using them with a finger is quite a challange.

obraz

obraz

Expected behavior

Quantity component with buttons should be consistent. Buttons should be bigger, especially on mobile.

Steps to reproduce

  1. Open product page, product quick view in category/home page or cart checkout
  2. Open browser dev tools, enable responsive mode and check viewport sizes when it breaks

PrestaShop version(s) where the bug happened

1.7.x.x

PHP version(s) where the bug happened

No response

If your bug is related to a module, specify its name and its version

No response

@SharakPL SharakPL added the Bug Type: Bug label Nov 17, 2021
@SharakPL SharakPL changed the title FO: Quantity touchspin can break and buttons are too small [FO] Quantity touchspin can break and buttons are too small Nov 17, 2021
@hibatallahAouadni
Copy link
Contributor

Hello @SharakPL

On iPhone 11 seems good to me, see the attached screenshot below:

image

Could you please provide the size of the device that you are testing on it 🙏
Please check and feedback.

Thanks!

@hibatallahAouadni hibatallahAouadni added 1.7.8.0 Affects versions NMI Status: issue needs more information Front-end Category: Front end FO Category: Front Office Old Products Page Concerns the old product page labels Nov 17, 2021
@SharakPL
Copy link
Contributor Author

SharakPL commented Nov 18, 2021

On english version it breaks below 351px on product page and 426px on cart page, but there are variables changing these numbers, eg. translations. Here's polish version of product page, where it breaks:

below 405px:

obraz

and even on tablets (768-991px):

obraz

My point is it shouldn't break at all, no matter the size or language, or your iPhone 😛

@khouloudbelguith
Copy link
Contributor

Hi @SharakPL,

I manage to reproduce the issue with PS1769, PS1778 and develop branch.
I have the issue on the Product page
image
I have the issue on the Shopping cart page
image

I'll add this to the debug backlog so that it's fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project's own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thanks!

@khouloudbelguith khouloudbelguith added 1.7.6.9 Affects versions Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified Shopping carts FO All the issues related to the Front Office Shopping Cart Verified The issue has been reproduced and removed NMI Status: issue needs more information 1.7.8.0 Affects versions labels Nov 18, 2021
@matks
Copy link
Contributor

matks commented Sep 21, 2023

Hi @SharakPL is this issue valid on Hummingbird ? 😉

@SharakPL
Copy link
Contributor Author

I don't think so. Bootstrap-touchspin isn't used anymore (at least it shouldn't 🤔) and quantity input group doesn't brake.

@hibatallahAouadni
Copy link
Contributor

Hi @SharakPL is this issue valid on Hummingbird ? 😉

The bug doesn't occur on HummingBird Theme.

@hibatallahAouadni hibatallahAouadni added 8.1.x Branch and removed 1.7.6.9 Affects versions labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch Bug Type: Bug FO Category: Front Office Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified Old Products Page Concerns the old product page Shopping carts FO All the issues related to the Front Office Shopping Cart Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

4 participants