Payment error with currency without two decimal places 1.7.8.1

[ocio87]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

It is identified that with the Colombian currency (Peso COP) it throws a payment error when there are no configured decimals or with a configured decimal.
When the two decimal places are configured in the COP currency, the order is created correctly with the Order status "Pending payment".
For the COP currency it is not necessary to have decimals. Is it possible to omit these decimals?

https://drive.google.com/file/d/17DRKRMeU3J3z1gHuOWOjODePW28Bxo8s/view

Expected behavior

It must allow the correct generation of the order with decimals equal to zero in the mode configuration as is currently the case with version 1.7.7.x

Steps to reproduce

1. Go to International - Location - Currency
2. Change Decimals to Zero

3. From the front office place an order.
4. It generates an error in the payment.

---

1. Install 1781 / 1780
2. Install the module COD
3. add the currency DZD or Colombian currency ( units of thousands)
4. Change precision of the currency to 0
5. Create an order from FO with COD
6. In the BO > Order > the status of the order is payment error

I manage to reproduce the issue with PS1780 / PS1781 using COD only
It is ok with PS1778 and 1769 => it's a regression on 1.7.8.0

PrestaShop version(s) where the bug happened

1.7.8.1

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

ps_wirepayment

[ocio87]

It happens with both the default Theme and the custom one.

[ocio87]

When it is left without decimals, in ordered orders it shows that there is no money to be paid, however the values are the same.

[khouloudbelguith]

Hi @ocio87,
I did not manage to reproduce the issue with PS1781.
I used different payment methods.
I attached a screen record
https://watch.screencastify.com/v/f4W96N4yOsrwC9EcAeM3

what is the exact payment method did you use?

Thanks!

[ocio87]

Please try with units of thousands and Colombian currency.

I ran unitless tests of thousands with cash payment and it worked fine.

The novelty is presented in units of thousands and without decimals.

[khouloudbelguith]

@ocio87, I tried with Colombian currency and it is ok ✔️
https://watch.screencastify.com/v/uzttVqH6sppk0oRMfiPK

Thanks to check and feedback.

[ocio87]

Hello,

Thanks for your time. Two things.

I was wrong, it is not with cash but with bank transfer (Bank Wire).

And second, look at what you saw in the video payment error in the order status.

[ocio87]

I did the test with the same product changing the price, one exceeding a thousand pesos and the other did not exceed a thousand pesos.

In the one that exceeds one thousand pesos, it shows a payment error and the one that does not exceed one thousand pesos is left with a successful order pending payment.

https://drive.google.com/file/d/1EU83A8ip7Dv4N-YlzuNG_F0OhC0p-CEr/view

All problems disappear when I put the two decimal places, I did tests with the same product exceeding a thousand pesos with two decimal places and the order is successful and the order status is correct.

https://drive.google.com/file/d/1-DbZ6uHBuMwGWcOu-HAAGoCQDY0xxr91/view

I also see a difference in the way the units of a thousand are shown, it shows me with a dot and it appears to you with a comma and decimals it shows me with a comma and you with a dot. I do not know if it can affect. However I appreciate if you can test it by putting the price of the product in thousands and paying with BankWire.

I appreciate if you can do the test again as previously reported.

A product with a price greater than 1000 pesos, without decimals and with Bankwire as a means of payment.

Thanks,

[khouloudbelguith]

@ocio87, the only way to reproduce the issue:

1. Install 1781 / 1780
2. Install the module COD
3. add the currency DZD or Colombian currency ( units of thousands)
4. Change precision of the currency to 0
5. Create an order from FO with COD
6. In the BO > Order > the status of the order is payment error

I manage to reproduce the issue with PS1780 / PS1781 using COD only

It is ok with PS1778 and 1769.

Can you please confirm the issue? I will update the first comment then.

I also see a difference in the way the units of a thousand are shown, it shows me with a dot and it appears to you with a comma and decimals it shows me with a comma and you with a dot. I do not know if it can affect.

This is a configuration, go to BO > Internation > LOcalization > Currencies > Edit any currency, for each language, we have a format

Thanks!

[ocio87]

I make some changes in the step by step

Install 1781 / 1780
Install the module ps_wirepayment

add the currency DZD or Colombian currency (COP) ( units of thousands)
Change precision of the currency to 0

Create an order from FO with ps_wirepayment - The product must exceed 1001 pesos
In the BO > Order > the status of the order is payment error

[khouloudbelguith]

@ocio87, sorry but using the ban wire module=> I have no issue.
I attached a screen record
https://watch.screencastify.com/v/AuRxLQlLPekaCi2rQNGf
Did I miss something?

Thanks!

[ahmedbdrn]

@khouloudbelguith

Hello, I'm currently facing the same issue but like you said only with COD.

Can I please have the solution for this problem?

PS: 1.7.8.1
PHP: 7.4

Thank you!

[ocio87]

Hello @khouloudbelguith

Apparently if it is a sectorized error, I would appreciate it if you can review it more thoroughly.

The store is updated from 1.7.7.8 and I waited for this version because the same thing happened with 1.7.8.0.

From my possibilities I will continue to review anyway.

[hibatallahAouadni]

Hello @ocio87

I was able to reproduce the issue with PrestaShop version 1.7.8.0 and COD module. I’ll add this to the debug backlog so that it’s fixed. And it's a regression!

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

[ocio87]

Hello,

Thank you @hibatallahAouadni

In the meantime I will continue to test other ways to update and confirm if I find a solution or the module that causes the error.

[khouloudbelguith]

Hi,

I reproduced the issue following these steps

Ordini.PrestaShop.mp4

Thanks!

[atomiix]

Fixed by #26824