Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in output of Profiling mode #26718

Closed
2 tasks done
lmeyer1 opened this issue Nov 23, 2021 · 3 comments · Fixed by #26731
Closed
2 tasks done

Errors in output of Profiling mode #26718

lmeyer1 opened this issue Nov 23, 2021 · 3 comments · Fixed by #26731
Assignees
Labels
1.7.8.0 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Performance Label: Which BO under menu is concerned PR available Solution: issue is being addressed Regression Type: regression
Milestone

Comments

@lmeyer1
Copy link
Contributor

lmeyer1 commented Nov 23, 2021

Prerequisites

Describe the bug and add screenshots

The display of the profiling output contains errors:

  • In Stopwatch SQL the times are labelled as milliseconds, but they are microseconds in reality
  • In Stopwatch SQL, the display of the stacktrace does not work, because <br> is HTML-escaped
  • In Doubles, the placeholders' HTML is also escaped

See screenshots:
2021-11-23_165341

2021-11-23_165407

Expected behavior

The display should be corrected as follows:

  • In Stopwatch SQL display the times as milliseconds and add digits after the comma to keep precision.
  • In Stopwatch SQL, do not escape <br>
  • In Doubles, do not escape the placeholders

Screenshots :
2021-11-23_165831
2021-11-23_165757

Steps to reproduce

  1. Enable Profiling mode
    • On your server, open the /config/defines.inc.php file.
    • Find this line (around line 43): define('PS_DEBUG_PROFILING', false);
    • In this line, change "false" to "true".
  2. Examine the output and notice the errors stated above.

PrestaShop version(s) where the bug happened

1.7.8.0

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

No response

@lmeyer1 lmeyer1 added the Bug Type: Bug label Nov 23, 2021
@hibatallahAouadni
Copy link
Contributor

hibatallahAouadni commented Nov 24, 2021

Hello @lmeyer1

Did you encounter these errors with PS1778 or any older version? and in which page (BO or FO)?
Please check and feedback.

Thanks!

@hibatallahAouadni hibatallahAouadni added 1.7.8.0 Affects versions BO Category: Back Office NMI Status: issue needs more information Performance Label: Which BO under menu is concerned labels Nov 24, 2021
@lmeyer1
Copy link
Contributor Author

lmeyer1 commented Nov 24, 2021

Hello Hiba,
I didn't try in an older version, only 1.7.8.0. The PR will be ready soon.
I noticed the problem in FO, but Profiling mode can be enabled in both. Thus the problems certainly appear on any page when Profiling mode is enabled.

@prestonBot prestonBot added the PR available Solution: issue is being addressed label Nov 24, 2021
@hibatallahAouadni
Copy link
Contributor

Hello @lmeyer1

I tried my best but I didn't manage to reproduce the issue in any page even with a product with specific price:

BO > Product page with specific price:

image

FO > Product page with specific price:

image


image

Please check and feedback.
Thanks!

@MatShir MatShir added Regression Type: regression Ready Status: Issue is ready to be worked on Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification and removed NMI Status: issue needs more information labels Dec 1, 2021
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Dec 9, 2021
@hibatallahAouadni hibatallahAouadni added the Fixed Resolution: issue closed because fixed label Dec 9, 2021
@hibatallahAouadni hibatallahAouadni added this to Not ready in PrestaShop 8.0.0 via automation Dec 9, 2021
@hibatallahAouadni hibatallahAouadni moved this from Not ready to Done in PrestaShop 8.0.0 Dec 9, 2021
@hibatallahAouadni hibatallahAouadni added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.0 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Performance Label: Which BO under menu is concerned PR available Solution: issue is being addressed Regression Type: regression
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants