Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion modal doesn't use the UI kit #26936

Open
MatShir opened this issue Dec 9, 2021 · 5 comments
Open

Deletion modal doesn't use the UI kit #26936

MatShir opened this issue Dec 9, 2021 · 5 comments
Labels
1.7.6.7 Affects versions BO Category: Back Office Feature Type: New Feature Front-end Category: Front end Good first issue Community: beginner-friendly issues Hacktoberfest Identify Hacktoberfest contributions Ready Status: Issue is ready to be worked on Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Verified The issue has been reproduced

Comments

@MatShir
Copy link
Contributor

MatShir commented Dec 9, 2021

Describe the bug and add screenshots
Modal deletion of cart rule page doesn't use the UI kIt

Capture d’écran 2021-12-09 à 15 22 36

Expected behavior
Use the UI kit

Steps to reproduce

  1. BO>SELL>Orders>Discount
  2. Click on Add new cart rule button
  3. Fill all infos
  4. Save
  5. Back to the list
  6. Click on Delete button
  7. See error > the modal doesn't use UI kit

Originally posted by @HanaRebaiQA in #26514 (comment)

@MatShir MatShir added Bug Type: Bug Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on Good first issue Community: beginner-friendly issues Front-end Category: Front end labels Dec 9, 2021
@hibatallahAouadni hibatallahAouadni added 1.7.6.7 Affects versions BO Category: Back Office labels Dec 9, 2021
@mparvazi
Copy link
Member

mparvazi commented Dec 15, 2021

This page (Cart Rules) designed in legacy theme.
I think the page must be migrated to new theme to solve this issue.
The grid tables that has action buttons in 3 dots style, has been designed by new theme.

Screenshot 2021-12-15 at 13-41-27 Pages • preload

@mparvazi
Copy link
Member

mparvazi commented Dec 15, 2021

The pages designed in legacy theme:

Order Settings > Statuses
Customer Settings > Groups
Customer Settings > Titles
Contact > Stores
Search > Tags
Locations > Countries
Locations > States
Taxes > Tax Rules
Shipping > Carriers
Theme & Logo > Pages Configuration
Design > Image Settings
Customer Service > Customer Service
Customer Service > Merchandise Returns
Attributes & Features > Attributes
Attributes & Features > Features
Discounts > Cart Rules
Discounts > Catalog Price Rules
Orders > Shopping Carts
Dashboard

@hibatallahAouadni hibatallahAouadni added the Verified The issue has been reproduced label Jan 12, 2022
@riyasavant
Copy link

Can I work on this issue?

@MatShir
Copy link
Contributor Author

MatShir commented Aug 14, 2023

Of course, you can work on the issue. We are happy to welcome new motivated contributor 🤗
Keep in mind that some of the page have been migrated, so the list might not be up-to-date. If you are willing to make a PR, I could double-check to update the list. Let me know :)

@MatShir MatShir added Feature Type: New Feature and removed Bug Type: Bug labels Aug 14, 2023
@MatShir
Copy link
Contributor Author

MatShir commented Aug 14, 2023

You can target 8.1.x branch !

@MatShir MatShir added the Hacktoberfest Identify Hacktoberfest contributions label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.6.7 Affects versions BO Category: Back Office Feature Type: New Feature Front-end Category: Front end Good first issue Community: beginner-friendly issues Hacktoberfest Identify Hacktoberfest contributions Ready Status: Issue is ready to be worked on Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

4 participants