Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording tooltip Traffic & SEO > Schema of URLs #27476

Closed
4 of 6 tasks
Julievrz opened this issue Jan 26, 2022 · 4 comments · Fixed by #27510
Closed
4 of 6 tasks

Improve wording tooltip Traffic & SEO > Schema of URLs #27476

Julievrz opened this issue Jan 26, 2022 · 4 comments · Fixed by #27510
Labels
BO Category: Back Office Feature Type: New Feature Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed SEO & URLs Label: Which BO under menu is concerned Traffic & SEO Label: Which BO under menu is concerned
Milestone

Comments

@Julievrz
Copy link
Contributor

Julievrz commented Jan 26, 2022

Prerequisites

Is your feature request related to a problem?

Following @MatShir's comment I'd like to suggest a new wording for the tooltip in Traffic & SEO > Schema of URLs.

Describe the solution you'd like

On Traffic & SEO > Schema of URLs, to add a fixed warning alert before the features (in Admin.Shopparameters.Notification):

'Before making any changes to the default pattern of your URLs, make sure to meet the following requirements:

  • The Friendly URL feature must be enabled
  • URL rewriting must be activated on your web server
  • All mandatory keywords (*) must be included in the route

You should also comply with the syntax:

  • Keywords must be in braces {keyword}
  • All keywords must be separated
  • As long as a keyword has an associated value, you can use the syntax {prepend:keyword:append} to add text before and after it'

Alternatives you've considered

No response

Additional context

No response

Do you plan to work on this feature?

  • I'm willing to contribute a formal specification.
  • I'm willing to provide any wireframes or design assets required for this feature.
  • I'm willing to submit a Pull Request that implements this feature.
  • I'm willing to help verify that the implemented feature works as intended and produces no unintended side effects.
@Julievrz Julievrz added the Feature Type: New Feature label Jan 26, 2022
@hibatallahAouadni hibatallahAouadni added BO Category: Back Office Needs Specs Status: issue needs to be specified SEO & URLs Label: Which BO under menu is concerned Traffic & SEO Label: Which BO under menu is concerned labels Jan 26, 2022
@hibatallahAouadni
Copy link
Contributor

Thanks @Julievrz 😉
Please check the labels, if there's a missing label then please add it 🙏

@MatShir MatShir added Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified labels Jan 26, 2022
@MatShir MatShir added this to Not ready in PrestaShop 8.0.0 via automation Jan 26, 2022
@MatShir MatShir moved this from Not ready to Ready in PrestaShop 8.0.0 Jan 26, 2022
@ghost
Copy link

ghost commented Jan 28, 2022

@Julievrz && @MatShir if I understand correctly you need something like this?

Capture d’écran de 2022-01-28 10-31-47

@MatShir
Copy link
Contributor

MatShir commented Jan 28, 2022

Yes exactly here but with alert medium-alert alert-warning :)

@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jan 28, 2022
@ghost
Copy link

ghost commented Jan 28, 2022

Done :) #27510

@Progi1984 Progi1984 added this to the 8.0.0 milestone Feb 1, 2022
@Progi1984 Progi1984 moved this from Ready to To be reviewed in PrestaShop 8.0.0 Feb 1, 2022
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Feb 1, 2022
@Progi1984 Progi1984 assigned ghost Feb 1, 2022
PrestaShop 8.0.0 automation moved this from To be reviewed to Done Mar 3, 2022
@prestashop-issue-bot prestashop-issue-bot bot added Fixed Resolution: issue closed because fixed and removed WIP Status: Work In Progress labels Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Feature Type: New Feature Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed SEO & URLs Label: Which BO under menu is concerned Traffic & SEO Label: Which BO under menu is concerned
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants