Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem withfilterProductContent hook in productcomments module #28342

Closed
2 tasks done
Tracked by #21404
Oksydan opened this issue Apr 26, 2022 · 2 comments · Fixed by PrestaShop/productcomments#137
Closed
2 tasks done
Tracked by #21404
Labels
1.7.7.8 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Hook Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module PR available Solution: issue is being addressed Productcomments Module: productcomments Verified The issue has been reproduced

Comments

@Oksydan
Copy link
Contributor

Oksydan commented Apr 26, 2022

Prerequisites

Describe the bug and add screenshots

Hook inside hookFilterProductContent should return $params.
Since it not returning it there is no arguments for another module registered to that hook and error occurs.

Type error: Argument 3 passed to HookCore::callHookOn() must be of the type array, null given, called in /Users/admin/code/nutropharma/classes/Hook.php on line 944

Expected behavior

When more modules than product comments are registered to filterProductContent no error should occur.

Steps to reproduce

  1. Install module productcomments_filter_test.zip
  2. Trun on debug mode.
  3. Go to product page.
  4. Error should be displayed.

PrestaShop version(s) where the bug happened

1.7.8.4

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

productcomments v5.0.1

@Oksydan Oksydan added Bug Type: Bug New New issue not yet processed by QA labels Apr 26, 2022
@hibatallahAouadni
Copy link
Contributor

Hello @Oksydan

I reproduce the issue with PS1778 and PS1785, see the attached screen record below:

issue_28342.mp4

I’ll add this to the debug backlog so that it’s fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

@hibatallahAouadni hibatallahAouadni added Major Severity: major bug > https://build.prestashop.com/news/severity-classification FO Category: Front Office Needs Specs Status: issue needs to be specified Productcomments Module: productcomments Hook 1.7.7.8 Affects versions Verified The issue has been reproduced Module Module and removed New New issue not yet processed by QA labels Apr 27, 2022
@Oksydan
Copy link
Contributor Author

Oksydan commented Apr 28, 2022

@hibatallahAouadni PR available

@hibatallahAouadni hibatallahAouadni added the PR available Solution: issue is being addressed label Apr 28, 2022
@khouloudbelguith khouloudbelguith added this to To do in Native modules integration via automation Aug 11, 2022
@khouloudbelguith khouloudbelguith moved this from To do to To be merged in Native modules integration Aug 11, 2022
Native modules integration automation moved this from To be merged to Done Aug 11, 2022
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Aug 11, 2022
@hibatallahAouadni hibatallahAouadni added the Fixed Resolution: issue closed because fixed label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.8 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Hook Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module PR available Solution: issue is being addressed Productcomments Module: productcomments Verified The issue has been reproduced
Projects
Development

Successfully merging a pull request may close this issue.

2 participants