Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autoupgrade] - Files like AdminReferrers.php isn't deleted during the Autoupgrade #29110

Closed
2 tasks done
Tracked by #25648
AureRita opened this issue Jul 19, 2022 · 2 comments
Closed
2 tasks done
Tracked by #25648
Labels
1.7.7.8 Affects versions Autoupgrade Module: autoupgrade BO Category: Back Office Bug Type: Bug Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module Verified The issue has been reproduced

Comments

@AureRita
Copy link
Contributor

Prerequisites

Describe the bug and add screenshots

When we do an Autoupgrade to the version 8.0.0, some files aren't delete, like the files AdminReferrers.php when they have to be deleted, that create some exceptions like on the page :

admin-dev/index.php?controller=AdminReferrers&addreferrer
image
admin-dev/index.php?controller=AdminReferrers
image
admin-dev/index.php?controller=AdminReferrers&updatereferrer=&id_referrer=1
image
admin-dev/index.php?controller=AdminReferrers&viewreferrer=&id_referrer=1
image

you can see the log of the autoupgrade juste here :
log.txt

Expected behavior

We want to delete the files during the autoupgrade so after that, we can have this type of notification :
image

Steps to reproduce

  1. Have a fresh install of Prestashop 1.7.8.6
  2. Go to BO > Modules > Module Catalog
  3. Download 1-Click Upgrade
  4. Uninstall modules : MBO - Metrics - Facebook - MarketfromGoogle - Welcome
  5. Do an autoupgrade from 1.7.8.6 to 8.0.0 where the adminrefferer page doesn't exist
  6. Go to [your_domain]/admin-dev/index.php?controller=AdminReferrers&addreferrer
  7. see exception

PrestaShop version(s) where the bug happened

1.7.8.6 - 1.7.7.8

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

Autoupgrade v4.15.0 - v4.14.1

@AureRita AureRita added Bug Type: Bug Major Severity: major bug > https://build.prestashop.com/news/severity-classification BO Category: Back Office Needs Specs Status: issue needs to be specified Autoupgrade Module: autoupgrade 1.7.7.8 Affects versions Verified The issue has been reproduced Module Module labels Jul 19, 2022
@RosaBenouamer
Copy link

@jolelievre : why these file have to be deleted ? If not what are the consequences ?

@Hlavtox
Copy link
Contributor

Hlavtox commented Dec 21, 2023

Fixed in autoupgrade 5.0.0

@Hlavtox Hlavtox closed this as completed Dec 21, 2023
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.8 Affects versions Autoupgrade Module: autoupgrade BO Category: Back Office Bug Type: Bug Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

3 participants