ps_crossselling: Does not take into account the shop in which the orders were placed

[lmeyer1]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

In multishop configuration, the algorithm to search for orders does not take into account the shop where the order was placed.

Suppose:

• in shop 1 product A was bought together with product B
• in shop 2 product A was bought together with product C

Observation:
In both shops, the module will display products B and C as bought together with product A

Expected behavior

The result should be contextualized to the shop:

• in shop 1 the module should display product B
• in shop 2 the module should display product C

This might be a minor issue if the two shops have the same owner. But in general, this module should take into account current shop

Steps to reproduce

Setup the products and the orders in the two shops as explained above:

Suppose:

• in shop 1 product A was bought together with product B
• in shop 2 product A was bought together with product C

Observation:
In both shops, the module will display products B and C as bought together with product A

PrestaShop version(s) where the bug happened

1.7.8.6

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

ps_crossselling 2.0.1

[AureRita]

Hi @lmeyer1

Thank you for your report, I find that this issue is maybe a dupplicate of this one : #16790. What do you think about it ?

Thank you for your PR 🚀

Waiting for your feedback

[lmeyer1]

@AureRita Certainly you didn't post the correct link. #16790 is completely unrelated and about order states.

[AureRita]

Hi @lmeyer1 ,

Yes, Indeed, I confused order status with order states, sorry,

So, I reproduce your issue with PrestaShop version 1.7.6.5/1.7.8.6 , I'll add this to the backlog

Thank you for the reporting and the PR

[MhiriFaten]

Hello @lmeyer1

I didn't reproduce the issue
Here is a screen record

Untitled_.Dec.5.2022.4_15.PM.webm

Did I miss something?
Waiting for your feedback.

[lmeyer1]

Hello @MhiriFaten ,
Your screen record is missing the most important part: It does not show the product details with the crossselling module in action after passing the orders.
Why did you try to reproduce it again? @AureRita did it successfully before.

[MhiriFaten]

Thank you @lmeyer1 for your feedback,

I tried to reproduce it again because I have to test the issue without PR since I am testing the PR.
I will check it with @AureRita