Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps_crossselling Allow for configuration of number of orders analyzed #29140

Open
6 tasks done
lmeyer1 opened this issue Jul 22, 2022 · 3 comments
Open
6 tasks done

ps_crossselling Allow for configuration of number of orders analyzed #29140

lmeyer1 opened this issue Jul 22, 2022 · 3 comments
Labels
BO Category: Back Office Cross selling Module: ps_crossselling Feature Type: New Feature Module Module Needs Specs Status: issue needs to be specified PR available Solution: issue is being addressed

Comments

@lmeyer1
Copy link
Contributor

lmeyer1 commented Jul 22, 2022

Prerequisites

Is your feature request related to a problem?

The current release is not working on larger installations (see #20874) because too many orders are inspected.

There have been number of resolution attempts for this, but unfortunately the diverge in the number of orders analyzed (see commits PrestaShop/ps_crossselling@e3b11e2 and PrestaShop/ps_crossselling@a26cec6). This may be due to the fact that the optimum number may vary a lot depending on the number of orders and products in the shop and the average number of products per order.

Describe the solution you'd like

A better solution would be to make this number configurable and take a reasonable default value.

Alternatives you've considered

None. As long as the performance problem in #20874 is not solved, the module cannot be used in production due to excessive slowdown.

Additional context

No response

Do you plan to work on this feature?

  • I'm willing to contribute a formal specification.
  • I'm willing to provide any wireframes or design assets required for this feature.
  • I'm willing to submit a Pull Request that implements this feature.
  • I'm willing to help verify that the implemented feature works as intended and produces no unintended side effects.
@lmeyer1 lmeyer1 added Feature Type: New Feature New New issue not yet processed by QA labels Jul 22, 2022
@kpodemski
Copy link
Contributor

PrestaShop/ps_crossselling#28

Have you seen this one?

@lmeyer1
Copy link
Contributor Author

lmeyer1 commented Jul 22, 2022

@kpodemski
I saw it, but did not yet work on it. I have to look at caching this afternoon. I think it is an important lever to improve performance.

@AureRita
Copy link
Contributor

Hi @lmeyer1
Thank you for your suggestion. The Product Team will take it into consideration for future developments.

Please be aware that there is no guarantee that this feature will be developed anytime soon.
Thanks @kpodemski for the quick proposition !

Thank you

@AureRita AureRita added Needs Specs Status: issue needs to be specified Cross selling Module: ps_crossselling Module Module BO Category: Back Office and removed New New issue not yet processed by QA labels Jul 25, 2022
@hibatallahAouadni hibatallahAouadni added the PR available Solution: issue is being addressed label Jul 27, 2022
@hibatallahAouadni hibatallahAouadni added this to To do in Native modules integration via automation Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Cross selling Module: ps_crossselling Feature Type: New Feature Module Module Needs Specs Status: issue needs to be specified PR available Solution: issue is being addressed
Projects
Development

No branches or pull requests

4 participants