Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO - Export current theme throw an exception when we create a custom language #29508

Open
2 tasks done
Tracked by #23176
khouloudbelguith opened this issue Sep 1, 2022 · 3 comments
Open
2 tasks done
Tracked by #23176
Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Design Component: Which BO section is concerned Good first issue Community: beginner-friendly issues Hacktoberfest Identify Hacktoberfest contributions Languages Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified Theme & logo Label: Which BO under menu is concerned Verified The issue has been reproduced

Comments

@khouloudbelguith
Copy link
Contributor

Prerequisites

Describe the bug and add screenshots

A custom language is manually created, In the BO > Design > Theme & Logo page, when we export the current theme, an exception displayed
image

Expected behavior

Ping @PrestaShop/product-team what do you think?
We should have a red alert that the language is not available, for example
image
Or the theme should be well downloaded?

Steps to reproduce

  1. Go to BO > International > Localization > Languages page
  2. Add a new language, in my case
    image
  3. Save
  4. Go to BO > Design > Theme & Logo page
  5. Click on Export current theme
  6. See exception
    image

PrestaShop version(s) where the bug happened

1.7.7.8, 1.7.8.7, 8.0.0beta

PHP version(s) where the bug happened

7.2, 7.4

If your bug is related to a module, specify its name and its version

No response

@khouloudbelguith khouloudbelguith added Bug Type: Bug New New issue not yet processed by QA Major Severity: major bug > https://build.prestashop.com/news/severity-classification BO Category: Back Office Needs Specs Status: issue needs to be specified Design Component: Which BO section is concerned Theme & logo Label: Which BO under menu is concerned Languages Label: Which BO under menu is concerned 1.7.7.8 Affects versions labels Sep 1, 2022
@hibatallahAouadni
Copy link
Contributor

Hello @khouloudbelguith

Thanks for reporting the issue!
I reproduce the issue with PS1786, see the attached screenshot below:

image

Thanks!

@hibatallahAouadni hibatallahAouadni added Verified The issue has been reproduced and removed New New issue not yet processed by QA labels Sep 2, 2022
@Hlavtox Hlavtox added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification and removed Major Severity: major bug > https://build.prestashop.com/news/severity-classification labels Jul 20, 2023
@matks matks added Hacktoberfest Identify Hacktoberfest contributions Good first issue Community: beginner-friendly issues labels Sep 21, 2023
@matks
Copy link
Contributor

matks commented Sep 21, 2023

As suggested above, instead of the page crashing we should have a red alert informing user that the language is not available

@hibatallahAouadni hibatallahAouadni added 8.0.0 Affected versions 8.1.x Branch and removed 1.7.7.8 Affects versions 8.0.0 Affected versions labels Sep 26, 2023
@HiCharly
Copy link
Contributor

HiCharly commented Dec 27, 2023

Hello

Here is a few questions to help determine the right way to proceed:

  • In case of a not translated language, should we prevent the full theme export ? If yes, to export the theme, user will need to translate the missing language or delete it, right?
  • What should be the message displayed yo the user ?
  • Additional point : Would it be better to try to export only active languages ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Design Component: Which BO section is concerned Good first issue Community: beginner-friendly issues Hacktoberfest Identify Hacktoberfest contributions Languages Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified Theme & logo Label: Which BO under menu is concerned Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

5 participants