CMS::getCMSContent doesn’t propagate $idShop when $idLang is not set

[bfontaine]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

It’s hard to know if this is a bug or expected behavior because this function has an empty docstring. Please discard this issue if this is an expected behavior.

The function’s signature is getCMSContent($idCms, $idLang = null, $idShop = null).

• CMS::getCMSContent(7) returns the content of CMS page of id 7 in the current language and shop
• CMS::getCMSContent(7, 1) returns the content of CMS page of id 7 in the language of id 1 and current shop
• CMS::getCMSContent(7, 1, 2) returns the content of CMS page of id 7 in the language of id 1 and shop of id 2
• CMS::getCMSContent(7, null, 2) returns the content of CMS page of id 7 in the current language and shop of id 2

Expected behavior

I believe the last behavior is a bug because I would expect it to return the content of CMS page of id 7 in the default language of the shop of id 2.

Steps to reproduce

Create a template with the following content:

{extends file='page.tpl'}
{block name='page_content'}
    {assign var=cms_content value=CMS::getCMSContent(7, null, 2)}
    {$cms_content.content nofilter}
{/block}

(you'll have to adapt it with your own ids)

Otherwise the issue is easy to see in the code:

PrestaShop/classes/CMS.php

Line 336 in 52a2498

public static function getCMSContent($idCms, $idLang = null, $idShop = null)

The function calls Configuration::get('PS_LANG_DEFAULT') as-is, without passing the optional argument $idShop.

PrestaShop version(s) where the bug happened

1.7.8.6

PHP version(s) where the bug happened

7.1

If your bug is related to a module, specify its name and its version

No response

[hibatallahAouadni]

The function’s signature is getCMSContent($idCms, $idLang = null, $idShop = null)
CMS::getCMSContent(7, null, 2) returns the content of CMS page of id 7 in the current language and shop of id 2
I believe this behavior is a bug because I would expect it to return the content of CMS page of id 7 in the default language of the shop of id 2.

is this the expected behavior or it's a bug?
Ping @PrestaShop/product-team can someone please answer @bfontaine question 🙏

Thanks in advance 🙏