BO - Import - Popup for data import has non-escaped text

[florine2623]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

When I do an import, at the end, there's a popup.
This popup should not have non escaped text:

It's a regression, it 1.7.8.7, it looked normal:

Expected behavior

I should see the text without the HTML elements.

Steps to reproduce

1. Go to BO > Advanced Parameters > Import
2. Download import file of your choice
3. Choose your file to import > match all fields > Import
4. See the popup appear at the end

PrestaShop version(s) where the bug happened

8.0.x, develop

PHP version(s) where the bug happened

7.4

If your bug is related to a module, specify its name and its version

No response

[sallemiines]

Hello @florine2623

Thanks for reporting the issue.
I reproduce the issue with PS1778 OK , PS1787 OK , develop / ps80x NOK , and PS800 OK ,
see the attached screen shot for develop/80x

see the attached screen shot for 800

Thank you !

[thomasDelaporte]

Hey,

It seems to me to be related to the modification of @yanmakouf (#29584) . If I understand a little the differences between 1.7.8 and 8.0.x, before the function htmlspecialchars was applied only on the text so in our case "[1]%percentage%[/1]% validated" while now the whole translation with the tags is passed in this function what makes that it is displayed as text.

I can't go further in solving the problem because I don't know the reasons of these changes.

For a quick solution, we can add the attribute html="true" in the template:
{l s="[1]%percentage%[/1]% validated" sprintf=[ '[1]' => '<span id="validate_progression_done">', '%percentage%' => '0', '[/1]' => '</span>' ] d="Admin.Advparameters.Notification" html="true"}

Good luck!

[eshraw]

Is it related to #29940 ?

[thomasDelaporte]

It seems related, I have the same problem where in the method replaceSpecialCharsWithLegacyFunctions, the variable $message includes the whole sentence:

For example <b>Visiteur</b> - Toutes les personnes n'ayant pas de compte client ou n'étant pas identifiées. and that if I do a htmlspecialchars it makes it display as text and more as an HTML element.

[jolelievre]

Fixed by #30415