Multistore - It is possible to select a default language for a shop that does not belong to the shop

[lmeyer1]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

1. It is possible to select a default language for a shop that does not belong to the shop.
   When selecting the wrong language as default language, it is added to the languages for the shop.

2. On the other hand, it is possible to remove the default language from the shop. The default language setting is not affected.

Expected behavior

1. It should not be possible to select a language as default language, that is not active in the current shop.

2. It should not be possible to remove the default language from a shop

Steps to reproduce

Given an environment with more than one language and more than one shop.

Setup

1. Create a clean installation of PS 1.7.8.7 following this step by step guide
2. Rename Shop A to French shop
3. In the BO, select French shop in the dropdown list
4. Go to International - Localization - Languages
5. On each language, click on Edit , and make sure, that in shop association only French is associated with French shop. In the shop association for German French shop must not be checked (but at least one other shop must be checked).

Reproduce bug 1)

1. Open Front Office and notice the URL http://localhost:8017/shop-a
2. Go to International - Localization - Localization
3. Look at the option Default language. Notice, that we can change all active languages, even the one that does not belong to French shop.
4. Select German and click Save
5. Go to International - Localization - Languages
6. Click on Edit on German. Notice, that in shop association French shop is now selected
7. Navigate to the front office, and notice that the URL has changed to http://localhost:8017/shop-a/fr/. It now contains the language. We have inadvertently changed all the URLs. Good by SEO.

Reproduce bug 2)
Currently French shop has both languages French and German, and German is the default language.

1. Go to International - Localization - Languages
2. Click on Edit on German's row. Deselect French Shop and save. (This should not be possible, since German is the default language).
3. In PHPMySQL look at the configuration PS_LANG_DEFAULT for `French Shop. You will find it still pointing to language 2 (German).
4. Go to International - Localization - Localization. Notice that German is still the default language.

PrestaShop version(s) where the bug happened

1.7.8.7

PHP version(s) where the bug happened

7.4

If your bug is related to a module, specify its name and its version

No response

[florine2623]

Hello @lmeyer1

For the bug 1), I have reproduced the issue only in BO
In my case, the language for my second shop should be FR instead of EN, is that right ?

Screen.Recording.2022-10-31.at.15.30.31.mov

In FO, the languages are the correct one for each shop.
ShopA: English

ShopB: French

For the bug 2), I'm not sure I understand well what I'm supposed to do.
I've tried disabling the language, it is not possible:

I've tried to deselect the language for a specific shop and I have a warning:

Could you send a screen record of your case please ?

Waiting for your feedback!
Thanks!

[lmeyer1]

@florine2623

I've tried disabling the language, it is not possible:

This is what I expected. I don't know why I didn't get that error. I'm installing a clean PrestaShop using Docker, the I will be able to test these bugs in a neutral reproductible environment and not on my production server.

[florine2623]

@PrestaShop/qa-functional ,

Could someone with Docker env try to reproduce this issue ? 🙏
Thanks!

[lmeyer1]

Hello @florine2623

1. I now updated the bug report above with a step by step guide starting at zero (i.e. clean installation).
2. I replaced all A and B with French and German to be very explicit

I know why you got the error

It is not related to the default shop, but it shows up, because Prestashop requires that at least one shop is checked. This why I added in the Setup, point 5:

In the shop association for German French shop must not be checked (but at least one other shop must be checked).

With this additional detail, you should be able to reproduce the issue without recurring to docker.

[HanaRebaiQA]

Hello @lmeyer1

Thanks for your report.
It seems that your issue is similar to this one #27617 which is fixed in this PR on the next PS1788 release.

Could you please confirm it?

Thank You!

[lmeyer1]

@HanaRebaiQA

No #27617 is not related with this issue. #27617 is about employee language and display in the BO.
This issue here is about the configuration of the language displayed in the Front Office.

[HanaRebaiQA]

Hello @lmeyer1

Thanks for your feedback.
I tried to reproduce you issue on PS1787, but I did not reproduce step 6 in Reproduce bug 1. But, when I checked in FO with french shop, which is associated to French language, the FO is in English

30171.mp4

What do you think?

Thank You!

[lmeyer1]

Hello Hana,
It was difficult for me to follow your screen cast. So I'm not sure where things went wrong.
You say:

But, when I checked in FO with french shop, which is associated to French language, the FO is in English

IMHO, This is enough to show that there is a bug. The French shop must display French only.

[HanaRebaiQA]

Hello @lmeyer1

Thanks for your feedback.
I have checked the same issue that I have communicated with PS1778 and i was able to reproduce it.
But, i was unable to reproduce the issue with 8.0.0 version.

It may be fixed on 8.0.0.

PS1778 : NOK ❌

1778.7.mp4

PS1787 : NOK ❌

199459833-07afc8a6-5fca-412b-b5cc-f7721907b3d8.mp4

PS8.0.0 : OK ✔️

8.0.0.mp4

Could you please check again?

Thank You!

[hibatallahAouadni]

Hello @lmeyer1

Closing the issue as it's not reproducible on 8.0.0 🎉

Thanks!