Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 product columns on mobile changed to 1 column since 1.7.8.8 #30706

Open
2 tasks done
naprba opened this issue Dec 31, 2022 · 6 comments
Open
2 tasks done

2 product columns on mobile changed to 1 column since 1.7.8.8 #30706

naprba opened this issue Dec 31, 2022 · 6 comments
Labels
1.7.8.8 Affects versions Bug Type: Bug FO Category: Front Office Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Old Products Page Concerns the old product page Ready Status: Issue is ready to be worked on Regression Type: regression Responsive Verified The issue has been reproduced

Comments

@naprba
Copy link

naprba commented Dec 31, 2022

Prerequisites

Describe the bug and add attachments

Hi Guys,
I noticed that after upgrading from 1.7.8.7 to 1.7.8.8 there is no more 2 product columns on mobile.
1.7.8.7 and a few previous versions already had 2 product columns implemented on mobile by default, but after the upgrade it is back to 1 column.
I am using the standard PrestaShop theme.

Expected behavior

2 product columns to remain on mobile after the upgrade.

Steps to reproduce

  1. Upgrade from 1.7.8.7 to 1.7.8.8 or install fresh 1.7.8.8 or 8.0.0 fresh install
  2. Access to FO
  3. Check mobile view
  4. See error > there's no two products in line, there's only one product per ligne

PrestaShop version(s) where the bug happened

1.7.8.8 & 8.0.0

PHP version(s) where the bug happened

No response

If your bug is related to a module, specify its name and its version

No response

@naprba naprba added Bug Type: Bug New New issue not yet processed by QA labels Dec 31, 2022
@hibatallahAouadni
Copy link
Contributor

Hello @naprba

I was able to reproduce the issue with PrestaShop version 1.7.8.8 and 8.0.0. It's a regression!

1.7.8.7 ✅

Screenshot 2023-01-02 at 10 33 50

1.7.8.8 ❌

Screenshot 2023-01-02 at 10 33 36

8.0.0 ❌

Screenshot 2023-01-02 at 10 33 10

I’ll add this to the debug backlog so that it’s fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

@hibatallahAouadni hibatallahAouadni added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification FO Category: Front Office Old Products Page Concerns the old product page Regression Type: regression Ready Status: Issue is ready to be worked on Front-end Category: Front end Responsive Verified The issue has been reproduced 1.7.8.8 Affects versions and removed New New issue not yet processed by QA labels Jan 2, 2023
@hibatallahAouadni hibatallahAouadni changed the title 2 product columns on mobile changed to 1 column after upgrade to 1.7.8.8 2 product columns on mobile changed to 1 column since 1.7.8.8 Jan 2, 2023
@SharakPL
Copy link
Contributor

SharakPL commented Jan 2, 2023

That's because when product has several labels they cover most of the image at 2 items per row, especially on some languages. IMO it's an improvement, not a bug 😉 Otherwise labels would have to be moved out of the image or made much smaller.

The only problem now is 250x250 images are too small. home_default size should be at least 350x350:

obraz

@Seb33300
Copy link
Contributor

Seb33300 commented Jan 3, 2023

If the issue comes from the label, the label should be smaller.
Having 2 products per line is far much better than only 1 IMO.

@SharakPL
Copy link
Contributor

SharakPL commented Jan 3, 2023

On 400px width and with labels improvements maybe it could be squeezed to 2 per row, but mobile starts at 320px so it still would be too small for classic theme.

New default theme for PS 8.x will have better configuration and shop admin will be able to set default size for the product grid item for mobile and desktop (work in progress).

@HartLarsson
Copy link

HartLarsson commented Jan 5, 2023

for completing the information about mobile screen resolutions:

image

image

320px is used by very old phones nowadays as show in the graph and tabel before.

Anyway lables must depends on caracter size of the device to accomodate the scaling in better way.
We should plan to take a look to use CSS3 Viewport Size instead of % or rem or media-queries because are supported by many browser already: https://caniuse.com/viewport-units

There are many tricks to use Viewport size that works also with desktop using a mix like:

font-size: calc(.5em + 1vw);

@web-cooking-factory
Copy link
Contributor

I agree for the two columns, it's much better.
Could be managed by adding a size to the Bootstrap grid if you want to separate 0-320 and 320-575.
Making the flags smaller would be an improvement as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.8 Affects versions Bug Type: Bug FO Category: Front Office Front-end Category: Front end Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Old Products Page Concerns the old product page Ready Status: Issue is ready to be worked on Regression Type: regression Responsive Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

6 participants