Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private comment not available on REST api (webservice) #30731

Open
2 tasks done
leccyril opened this issue Jan 4, 2023 · 4 comments
Open
2 tasks done

Private comment not available on REST api (webservice) #30731

leccyril opened this issue Jan 4, 2023 · 4 comments
Labels
1.7.8.x Branch BO Category: Back Office Feature Type: New Feature Hacktoberfest Identify Hacktoberfest contributions Order Component: Which BO section is concerned Quickwin A relatively easy to do Ready Status: Issue is ready to be worked on Waiting for PM Status: action required, waiting for product feedback WS Category: Web Service

Comments

@leccyril
Copy link

leccyril commented Jan 4, 2023

Prerequisites

Describe the bug and add attachments

I developed a dahboard retrieving data from REST API, i tried to look for private comment (not order comment for customer) but the private comment displayed in the client block

Expected behavior

private comment available

Steps to reproduce

Try to execute rest API calls

PrestaShop version(s) where the bug happened

1.7.8.x

PHP version(s) where the bug happened

7.1

If your bug is related to a module, specify its name and its version

No response

@leccyril leccyril added Bug Type: Bug New New issue not yet processed by QA labels Jan 4, 2023
@sallemiines
Copy link
Contributor

Hello @leccyril

Thanx for reporting the issue.

could you please provide more infos, screenshots, file/code/api that you use to display the private comment in the order ?

Thank you !

@sallemiines sallemiines added WS Category: Web Service 1.7.8.x Branch Waiting for author Status: action required, waiting for author feedback NMI Status: issue needs more information Customer Component: Which BO section is concerned and removed New New issue not yet processed by QA labels Jan 5, 2023
@leccyril
Copy link
Author

leccyril commented Jan 6, 2023

Hello,

i am using webservice API rest

for instance i try this URL :
http://domain.com/api/messages?display=full&output_format=JSON&ws_key=lllllll

and i look for my order (i added a private comment as employee on backend detail order) but nothing in messages the only entry is this :

   {
            "id": 505,
            "id_cart": "10927",
            "id_order": "1334",
            "id_customer": "130",
            "id_employee": "0",
            "message": "Commande manuelle - Employé : A. ADMIN",
            "private": "1",
            "date_add": "2022-11-28 09:20:12"
        }

and here in the backend we have 2 types of messages

image

for retrieving the second one i get by customer_thread but for the private one i dont know ho to get it by the order or any other way

based on this URL
https://devdocs.prestashop-project.org/8/webservice/resources/

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label Jan 6, 2023
@florine2623
Copy link
Contributor

Hello @leccyril ,

This is not a bug, more an improvement.

Screenshot 2023-01-06 at 17 02 15

Thank you for your suggestion. The Maintainer Team will take it into consideration for future developments.
Please be aware that there is no guarantee that this feature will be developed anytime soon. If this is important to you, we strongly suggest you consider hiring a specialist to help you create it.

If you are willing to implement this feature into PrestaShop as a Pull Request, the teams will be happy to help you by ensuring that it is appropriate and coherent with the rest of the project. If that is the case, please let us know!

Thanks!

@florine2623 florine2623 added Waiting for PM Status: action required, waiting for product feedback Order Component: Which BO section is concerned Feature Type: New Feature BO Category: Back Office Needs Specs Status: issue needs to be specified and removed NMI Status: issue needs more information Customer Component: Which BO section is concerned Bug Type: Bug labels Jan 6, 2023
@MatShir MatShir added Ready Status: Issue is ready to be worked on Quickwin A relatively easy to do Hacktoberfest Identify Hacktoberfest contributions and removed Needs Specs Status: issue needs to be specified labels Sep 21, 2023
@jimNutrix
Copy link

jimNutrix commented Apr 16, 2024

This is very easy, you just have to do exactly the same thing that is done for note in classes/order.php but with order_note
However I wonder what is even this note column, because it's all empty in my database. Maybe we should replace all "note" with "order_note" in this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.x Branch BO Category: Back Office Feature Type: New Feature Hacktoberfest Identify Hacktoberfest contributions Order Component: Which BO section is concerned Quickwin A relatively easy to do Ready Status: Issue is ready to be worked on Waiting for PM Status: action required, waiting for product feedback WS Category: Web Service
Projects
None yet
Development

No branches or pull requests

5 participants