Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation on Multistore panel #30741

Open
2 tasks done
Tracked by #13863
SNor42 opened this issue Jan 5, 2023 · 4 comments
Open
2 tasks done
Tracked by #13863

Missing translation on Multistore panel #30741

SNor42 opened this issue Jan 5, 2023 · 4 comments
Labels
1.7.8.7 Affects versions BO Category: Back Office Bug Type: Bug Multistore Label: Which BO under menu is concerned Needs Specs Status: issue needs to be specified Translations Label: Which BO under menu is concerned Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Verified The issue has been reproduced

Comments

@SNor42
Copy link

SNor42 commented Jan 5, 2023

Prerequisites

Describe the bug and add attachments

Missing the placeholder translation option in multistore dropdown list search input field:
kép
kép

File: src\PrestaShopBundle\Resources\views\Admin\Multistore\header.html.twig

Code:

<div class="multishop-modal-search-container">
<i class="material-icons">search</i>
<input type="text" class="form-control multishop-modal-search js-multishop-modal-search" placeholder="Search shop name" data-no-results="{{ "No results found for"|trans({}, 'Admin.Global') }}" data-searching="{{ "Searching for"|trans({}, 'Admin.Global') }}">
</div>

Expected behavior

<div class="multishop-modal-search-container">
<i class="material-icons">search</i>
<input type="text" class="form-control multishop-modal-search js-multishop-modal-search" placeholder="{{ "Search shop name"|trans({}, 'Admin.Global') }}" data-no-results="{{ "No results found for"|trans({}, 'Admin.Global') }}" data-searching="{{ "Searching for"|trans({}, 'Admin.Global') }}">
</div>

Steps to reproduce

1- Change your BO language ( Languages Other Than English )
2 - Enable multistore option and create two shops.
3 - Check Multistore header

PrestaShop version(s) where the bug happened

1.7.8.7

PHP version(s) where the bug happened

7.2

If your bug is related to a module, specify its name and its version

No response

@SNor42 SNor42 added Bug Type: Bug New New issue not yet processed by QA labels Jan 5, 2023
@sallemiines
Copy link
Contributor

Hello @SNor42

Thanx for reporting the issue.

Did you change the BO language ? I can't manage to reproduce your issue when I follow your steps !
image

Please check & feedback !

Thnak you !

@sallemiines sallemiines added BO Category: Back Office Translations Label: Which BO under menu is concerned Multistore Label: Which BO under menu is concerned 1.7.8.7 Affects versions Waiting for author Status: action required, waiting for author feedback NMI Status: issue needs more information Bug Type: Bug and removed Bug Type: Bug New New issue not yet processed by QA labels Jan 5, 2023
@SNor42
Copy link
Author

SNor42 commented Jan 5, 2023

Yes, I've changed to BO language to hungarian.

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label Jan 5, 2023
@sallemiines
Copy link
Contributor

sallemiines commented Jan 5, 2023

Yes, I've changed to BO language to hungarian.

Thank you for the quick reply !

I reproduce your issue with ps 1778 ,ps 1787 , ps 1788 , ps 800

image

Thank you !

@sallemiines sallemiines added Needs Specs Status: issue needs to be specified 1.7.7.8 Affects versions Verified The issue has been reproduced and removed NMI Status: issue needs more information 1.7.7.8 Affects versions labels Jan 5, 2023
@hibatallahAouadni hibatallahAouadni self-assigned this Jan 6, 2023
@hibatallahAouadni hibatallahAouadni added TBR Status: issue to be reproduced and removed Needs Specs Status: issue needs to be specified labels Jan 6, 2023
@florine2623
Copy link
Contributor

This has been reproduced also on develop branch :

Screenshot 2023-03-09 at 14 17 38

@florine2623 florine2623 added Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified and removed TBR Status: issue to be reproduced labels Mar 9, 2023
@florine2623 florine2623 changed the title Missing translation Missing translation on Multistore panel Mar 9, 2023
@hibatallahAouadni hibatallahAouadni removed their assignment Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.7 Affects versions BO Category: Back Office Bug Type: Bug Multistore Label: Which BO under menu is concerned Needs Specs Status: issue needs to be specified Translations Label: Which BO under menu is concerned Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

4 participants