Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0.2 build 2 - BO - Translation of module with RTL language #31731

Open
2 tasks done
florine2623 opened this issue Mar 10, 2023 · 3 comments
Open
2 tasks done

8.0.2 build 2 - BO - Translation of module with RTL language #31731

florine2623 opened this issue Mar 10, 2023 · 3 comments
Labels
8.0.2 Affects versions BO Category: Back Office Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules Component: Which BO section is concerned Ready Status: Issue is ready to be worked on Regression Type: regression Translations Label: Which BO under menu is concerned Verified The issue has been reproduced

Comments

@florine2623
Copy link
Contributor

Prerequisites

Describe the bug and add attachments

I have this page displayed when I try to translate my modules.
Screenshot 2023-03-10 at 17 16 41

With this page I can't translate anything.

Screen.Recording.2023-03-10.at.17.19.14.mov

It's a regression, on 1.7.8.8 and 8.0.1, it was OK

Expected behavior

This page should be displayed :
Screenshot 2023-03-10 at 17 16 19

Steps to reproduce

  1. Go to BO > International > Translation > Add RTL language : Arabic for example
  2. Change your BO language to Arabic
  3. Go to International > Translation > Choose this config > SAVE

Screenshot 2023-03-10 at 17 19 48

4. See the old page displayed

PrestaShop version(s) where the bug happened

8.0.2

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

@florine2623 florine2623 added Bug Type: Bug BO Category: Back Office Translations Label: Which BO under menu is concerned Regression Type: regression Module Module New New issue not yet processed by QA 8.0.x Branch labels Mar 10, 2023
@florine2623 florine2623 changed the title BO - Translation of module with RTL language 8.0.2 build 2 - BO - Translation of module with RTL language Mar 10, 2023
@florine2623 florine2623 added the Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification label Mar 10, 2023
@hibatallahAouadni hibatallahAouadni added Modules Component: Which BO section is concerned Ready Status: Issue is ready to be worked on Verified The issue has been reproduced and removed Module Module New New issue not yet processed by QA labels Mar 10, 2023
@Hlavtox
Copy link
Contributor

Hlavtox commented Mar 10, 2023

I have tested it on 8.0.x branch and I have slightly different results.

Block reassurance - new translation system - works ✅
reassurance

Block wishlist - new translation system - doesnt work 🔴
blockwishlist

My module - old translation system - works ✅
legacy

@hibatallahAouadni hibatallahAouadni added 8.0.2 Affects versions and removed 8.0.x Branch labels May 3, 2023
@venditdevs
Copy link
Contributor

venditdevs commented May 11, 2023

@hibatallahAouadni @florine2623 @Hlavtox

Some more information on this.

Prestashop 8.0.3 and 8.0.4 in combination with PHP 8.1 results in this error while translating a module:

unknow error on line 1092 in file:
/home/username/domains/domain.com/public_html/controllers/admin/AdminTranslationController.php {8192}_strtolower(): Parsing null to parameter #1 ($string) of type string is deprecated.

Prestashop 8.0.4 with PHP 8.0 results in this error
 
unknown error on line 114 in file:
/home/username/domains/domain.com/public_html/vendor/smarty/smarty/libs/sysplugins/smarty_internal_compile_private_modifier.php [16384] Using php-function "stripslashes" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier.

You'll only see this errors with debug mode on, if debug mode is disabled you'll only get a 503 error directly after saving the translation change(s)

If we translate in the BO with PHP7.4 everything works as expected.

Conclusion: Prestashop 8.0.3/4 is NOT (fully) compatible with PHP8 or PHP8.1

@lmeyer1
Copy link
Contributor

lmeyer1 commented May 25, 2023

I have the same errorUsing php-function "stripslashes" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier., but in a different context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0.2 Affects versions BO Category: Back Office Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules Component: Which BO section is concerned Ready Status: Issue is ready to be worked on Regression Type: regression Translations Label: Which BO under menu is concerned Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

5 participants