Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The method uninstallPrestaShop16Module use code removed in v8 #31799

Open
2 tasks done
Tracked by #27214
kpodemski opened this issue Mar 15, 2023 · 1 comment
Open
2 tasks done
Tracked by #27214

The method uninstallPrestaShop16Module use code removed in v8 #31799

kpodemski opened this issue Mar 15, 2023 · 1 comment
Assignees
Labels
1.7.0.0 Affects versions Bug Type: Bug CO Category: Core Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on Refactoring Type: Refactoring Verified The issue has been reproduced

Comments

@kpodemski
Copy link
Contributor

kpodemski commented Mar 15, 2023

Prerequisites

Describe the bug and add attachments

In this piece of code:

public function uninstallPrestaShop16Module()
    {
        if (!Module::isInstalled(self::PS_16_EQUIVALENT_MODULE)) {
            return true;
        }

        // Data migration
        Configuration::updateValue('BANNER_IMG', Configuration::getInt('BLOCKBANNER_IMG'));
        Configuration::updateValue('BANNER_LINK', Configuration::getInt('BLOCKBANNER_LINK'));
        Configuration::updateValue('BANNER_DESC', Configuration::getInt('BLOCKBANNER_DESC'));

        $oldModule = Module::getInstanceByName(self::PS_16_EQUIVALENT_MODULE);
        if ($oldModule) {
            $oldModule->uninstall();
        }

        return true;
    }

We use Configuration::getInt, which was removed and replaced by Configuration:: getConfigInMultipleLangs

It is causing issues with the upgrade. It basically breaks the upgrade if you start with 1.6 to 1.7, and then 1.7 to v8.

Expected behavior

Refacto is needed

Steps to reproduce

  1. Look at the code
  2. Look at the core
  3. See the method is no longer in Configuration.php in PrestaShop 8.0 :)

but start with 0. Trust me on this one, and move on :-) So, please do not test this I'm sure it's a valid problem, and I'll solve this.

PrestaShop version(s) where the bug happened

n/a

PHP version(s) where the bug happened

n/a

If your bug is related to a module, specify its name and its version

n/a

@kpodemski kpodemski added Bug Type: Bug New New issue not yet processed by QA labels Mar 15, 2023
@kpodemski kpodemski self-assigned this Mar 15, 2023
@paulnoelcholot
Copy link

Hello @kpodemski,

Could you please provide us with more info ?

  • PrestaShop version
  • Label

You don't know how to get this information? Please read the following article: How to create a bug report.

Thank you

@paulnoelcholot paulnoelcholot added Waiting for author Status: action required, waiting for author feedback NMI Status: issue needs more information and removed New New issue not yet processed by QA labels Mar 16, 2023
@kpodemski kpodemski added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification 1.7.x Branch Ready Status: Issue is ready to be worked on and removed Waiting for author Status: action required, waiting for author feedback NMI Status: issue needs more information labels Mar 16, 2023
@hibatallahAouadni hibatallahAouadni added CO Category: Core 1.7.0.0 Affects versions Refactoring Type: Refactoring Verified The issue has been reproduced and removed 1.7.x Branch labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.0.0 Affects versions Bug Type: Bug CO Category: Core Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on Refactoring Type: Refactoring Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

3 participants