Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to activate the module for the context of the shop with GDPR 2.0.x #32211

Open
2 tasks done
paulnoelcholot opened this issue Apr 19, 2023 · 4 comments
Open
2 tasks done
Labels
8.0.1 Affects versions BO Category: Back Office Bug Type: Bug GDPR Module: psgdpr Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module Modules Component: Which BO section is concerned Multistore Label: Which BO under menu is concerned PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Regression Type: regression Verified The issue has been reproduced

Comments

@paulnoelcholot
Copy link

Prerequisites

Describe the bug and add attachments

With the release PR 209 of GDPR (PrestaShop/psgdpr#209) , if the multistore is activated, from the GDPR module it is not possible to activate the module for the context of the shop

https://watch.screencastify.com/v/k1WXx7518DgiaLZwmDNb

Expected behavior

It should be possible to enable the module for the context of the shop

Steps to reproduce

  1. activated multistore
  2. Created a second shop
  3. Go to GDPR module
  4. Clic to "Activate module for this shop context: shop NAME_OF_THE_SHOP" checkbox
  5. see error

PrestaShop version(s) where the bug happened

8.0.1

PHP version(s) where the bug happened

7.4

If your bug is related to a module, specify its name and its version

ps_gdpr 2.0.1

Your company or customer's name goes here (if applicable).

No response

@paulnoelcholot paulnoelcholot added Bug Type: Bug New New issue not yet processed by QA BO Category: Back Office Modules Component: Which BO section is concerned Regression Type: regression GDPR Module: psgdpr 8.0.1 Affects versions labels Apr 19, 2023
@florine2623
Copy link
Contributor

Hello @paulnoelcholot ,

Tested with the pre-release of v2.0.1. Not with PR 209.
I have have indeed an issue, also by just clicking on Configure while on Groupe Default context :

Attempted to load class "ConsentRepository" from namespace "PrestaShop\Module\Psgdpr\Repository".
Did you forget a "use" statement for another namespace?

Screenshot 2023-04-20 at 10 16 33

Screen.Recording.2023-04-20.at.10.20.01.mov

@florine2623 florine2623 added Major Severity: major bug > https://build.prestashop.com/news/severity-classification Verified The issue has been reproduced Module Module and removed New New issue not yet processed by QA labels Apr 20, 2023
@florine2623 florine2623 added this to To do in Native modules integration via automation Apr 20, 2023
@florine2623 florine2623 added the Multistore Label: Which BO under menu is concerned label Apr 20, 2023
@jolelievre
Copy link
Contributor

Just a small complement on this issue, here are the problems identified:

  • the checkbox deactivates the module on its global state (module.active) instead of its multishop state (module_shop table association)
  • the configuration of a disabled module (globally) should not be possible/accessible the user should be redirected to the module manager page with a flash message explaining that you can't configure a disabled module
  • seems like the checkbox is always checked regardless of the module's status

@hibatallahAouadni hibatallahAouadni added the Ready Status: Issue is ready to be worked on label May 3, 2023
@matks matks changed the title Module GDPR multistore It is not possible to activate the module for the context of the shop with GDPR 2.0.x May 4, 2023
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jun 7, 2023
@WahbiPS WahbiPS added the Waiting for QA Status: action required, waiting for test feedback label Jun 12, 2023
@florine2623
Copy link
Contributor

Hello @paulnoelcholot @jolelievre

Tested with psgdpr v2.0.1 pre-release, PS 8.0.4 and PHP 7.4.

I don't reproduce the issue mentioned by @paulnoelcholot and myself.

Regarding @jolelievre 's comment :

  • the checkbox deactivates the module on its global state (module.active) instead of its multishop state (module_shop table association) -> ✅ fixed
  • the configuration of a disabled module (globally) should not be possible/accessible the user should be redirected to the - module manager page with a flash message explaining that you can't configure a disabled module : ❌
  • seems like the checkbox is always checked regardless of the module's status -> ✅ fixed
Screen.Recording.2023-06-12.at.15.07.52.mov

@WahbiPS, what do you think ?

@AureRita
Copy link
Contributor

AureRita commented Oct 4, 2023

Hi !

I open this issue again because this one issue is still on Prestashop 8.1.2 with PSGDPR 2.0.3
For this issue, you need to be on all shops to have the issue, as you can see in this video :

Untitled_.Oct.4.2023.5_01.PM.webm

@AureRita AureRita reopened this Oct 4, 2023
Native modules integration automation moved this from Done to In progress Oct 4, 2023
@AureRita AureRita added New New issue not yet processed by QA Ready Status: Issue is ready to be worked on and removed New New issue not yet processed by QA Waiting for QA Status: action required, waiting for test feedback labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0.1 Affects versions BO Category: Back Office Bug Type: Bug GDPR Module: psgdpr Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module Modules Component: Which BO section is concerned Multistore Label: Which BO under menu is concerned PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Regression Type: regression Verified The issue has been reproduced
Projects
Development

No branches or pull requests

7 participants