Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarty user deprecation notices about php function 'implode' #32966

Open
2 tasks done
lmeyer1 opened this issue Jun 21, 2023 · 1 comment
Open
2 tasks done

smarty user deprecation notices about php function 'implode' #32966

lmeyer1 opened this issue Jun 21, 2023 · 1 comment
Labels
8.0.4 Affects versions BO Category: Back Office Bug Type: Bug Faceted search Module: ps_facetedsearch Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Module Module PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Regression Type: regression Verified The issue has been reproduced

Comments

@lmeyer1
Copy link
Contributor

lmeyer1 commented Jun 21, 2023

Prerequisites

Describe the bug and add attachments

I'm on a BO with debug enabled, I then edit a faceted search category.
This is the error message I get.
2023-06-21_151149

I get it only when the smarty cache is empty. It does not reproduce on reload of the page.

Related to #32703

Expected behavior

There should no usage of deprecated smarty features.

Steps to reproduce

On an installation with debug enabled (define('_PS_MODE_DEV_', true);) and ps_facetedsearch installed

  • log into BO
  • go to ps_facetedsearch configuration
  • in "Filter models" click on "Create model" or edit an existing model
  • Notice the error in a modal.
  • If needed, empty the folder var/cache

PrestaShop version(s) where the bug happened

8.0.4

PHP version(s) where the bug happened

8.0

If your bug is related to a module, specify its name and its version

ps_facetedsearch (version not important, bug is in core)

Your company or customer's name goes here (if applicable).

Société Biblique de Genève

@lmeyer1 lmeyer1 added Bug Type: Bug New New issue not yet processed by QA labels Jun 21, 2023
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jun 21, 2023
@aniszr
Copy link

aniszr commented Jun 21, 2023

Hello,

I managed to reproduce this issue with PS 8.0.4 and found same problem, in PS 1.7.8.9 I couldn't reproduce it.
It looks like a regression to me!
Nice catch 👍

Thanks

@hibatallahAouadni hibatallahAouadni added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification BO Category: Back Office Faceted search Module: ps_facetedsearch Regression Type: regression Ready Status: Issue is ready to be worked on Verified The issue has been reproduced Module Module 8.0.4 Affects versions and removed New New issue not yet processed by QA labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0.4 Affects versions BO Category: Back Office Bug Type: Bug Faceted search Module: ps_facetedsearch Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Module Module PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Regression Type: regression Verified The issue has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants