Default language and assigned shop languages inconsistencies

[cruftex]

Prerequisites

• I understand and accept the project's code of conduct.
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add attachments

When the default shop language is not within the assigned languages (Which is a configuration error), the shop looks working normal. However, when an order is made, the confirmation mail of the payment is sent in the default language and not in the user language, and the redirect to the payment confirmation page resulted in a wrong URL and yields a 404.

Expected behavior

It is a misconfiguration, so, according to GIGO everything is allowed to happen. OTOH, the behaviour reveals some inconsistencies which might cause problems in other scenarios as well.

Possible improvements:

• Allow to select the shop default language from the supported set of languages only
• Refuse operation at all, if default language is not in the supported set of languages
• Alternatively, add the default language implicitly to the set of supported languages. This would save a lot of trouble.
• Remove inconsistencies in the code, see below

Findings in the code:

The FrontController creates the cart with the language from the cookie.

        if (!isset($cart) || !$cart->id) {
            $cart = new Cart();
            $cart->id_lang = (int) $this->context->cookie->id_lang;

But usually Context::getContext()->language->id is used. The problem is that the both might differ, because id_lang in the cookie is not sanitised and may be a not supported language.

The PaymentModuleCore->validateOrder changes the context language to the cart language.

            $this->context->language = $this->context->cart->getAssociatedLanguage();

This is correct behaviour, because we want to send the mail in the language present while ordering. However, the context language needs to be restored to the initial request language after that.

This is all low prio. However, I thought it's worth writing down. Let me know whether this is helpful or not.

Steps to reproduce

I am using multi site, however, it should be the same with a single shop.

1. Install English and German
2. Enable German only
3. Set default Language to English
4. Make test order with a payment provider that does a redirect to the confirmation page (e.g. Stripe)
5. Confirmation mail is send in English
6. Redirect goes to /order-confirmation instead of /bestellbestatigung and yields 404

PrestaShop version(s) where the bug happened

8.0.4

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

headissue GmbH

[sallemiines]

Hello @cruftex

I didn't manage to reproduce your issue with PS 804 !
Could you please provide us some screenshots or screen recorder for the result you had !

Waiting for your feedback
Thank you !

[cruftex]

@sallemiines:
Thanks for trying to reproduce.

I just checked with a single site. When I try to disable the default language, I get the error:

You cannot change the status of the default language.

That looks great!

So the problem is emerging with multi store feature only.

• Fresh 8.0.4 from docker, with EN and DE, config settings:
  PS_LANGUAGE: "en"
  PS_COUNTRY: "de"
• Enable multi store
• Optional:
  • Localization > Languages > Languages Tab, click Edit on "English", remove shop association and save
  • This results in: "This field cannot be empty.", Good!
• Add a second store
• Localization > Languages > Languages Tab, click Edit on "English", remove shop association from shop "PrestaShop" and save
• Association English cloud be removed

MariaDB [shop]> select * from ps_lang_shop;
+---------+---------+
| id_lang | id_shop |
+---------+---------+
|       1 |       2 |
|       2 |       1 |
|       2 |       2 |
+---------+---------+
3 rows in set (0.001 sec)

Shop 1 has only language 2 associated, while the default is 1 (English).

• Go to the shop, -> it has UI language German (associated ID 2).
• Put a product in the cart and check cart language via SQL ->

MariaDB [shop]> select id_cart, id_lang, date_add   from ps_cart;
+---------+---------+---------------------+
| id_cart | id_lang | date_add            |
+---------+---------+---------------------+
|       1 |       1 | 2023-06-23 11:21:39 |
|       2 |       1 | 2023-06-23 11:21:39 |
|       3 |       1 | 2023-06-23 11:21:39 |
|       4 |       1 | 2023-06-23 11:21:39 |
|       5 |       1 | 2023-06-23 11:21:39 |
|       6 |       1 | 2023-06-23 12:06:18 |
+---------+---------+---------------------+
6 rows in set (0.001 sec)

Although the shop speaks only German, the cart language is English.
This will lead then to the wrong confirmation mail and redirect resulting in 404.

There should be more scenarios that are problematic, when exploiting the several contributing factors more isolated. For example:

• Fresh single site, with en and de, en is default
• put product in the cart
• change language to de
• complete order in de / German language
• order confirmation will (possibly) be send in English, expected: German

[AureRita]

Hi @cruftex

Thank you for the details, I reproduce the issue with PrestaShop version 1.7.8.9. Asi you can see :

Untitled_.Jun.26.2023.2_30.PM.webm

I'll add this to the backlog so it can be fixed.

Please be aware that some issues might take a very long time to be resolved.

If you fix the issue on your end, please contribute it back to the project. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thanks

[JakubSVK]

Hi !

Please check if you have a valid language for your correct store. You should turn off - Set language from browser and Default country. Maybe it helps

I had same problem.

[cruftex]

@JakubSVK
Thanks. I actually "fixed" my problem once I discovered that I had a misconfiguration and that I set the default language to English while only supporting German. Once this was corrected, the problem was gone.