Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate an alpha release of the theme in the project #36182

Open
1 of 5 tasks
Tracked by #36145
jolelievre opened this issue May 17, 2024 · 1 comment
Open
1 of 5 tasks
Tracked by #36145

Integrate an alpha release of the theme in the project #36182

jolelievre opened this issue May 17, 2024 · 1 comment
Assignees
Labels
develop Branch Theme & logo Label: Which BO under menu is concerned

Comments

@jolelievre
Copy link
Contributor

jolelievre commented May 17, 2024

This is the step to integrate an alpha version in the core, the theme will be accessible but not used as the default one

  • Release the theme with the latest changes into a 0.2.0 version (see this PR Release 0.2.0 hummingbird#600 - the version needs to be bumped to 0.2.0)
  • Prepare a page in devdocs that explains the technical constraints for this theme (can be empty at first but we need the URL for the following task) The page can later be enriched
    • Explain that the theme is based on bootstrap5 and won't be compatible with all modules until they handle the theme
    • Explain the trick about integrating the Bootstrap Compatibility Layer (we still need to decide if it should be in the core, in the theme or in the module)
  • Integrate hummingbird 0.2.0 into composer, adapt UI tests that don't need to install the theme anymore, integrate a warning popup when the theme is enabled to warn about bootstrap with a link to devdoc for more details (also see this issue Flag indicating the use of a new version of Bootstrap for developers hummingbird#581)
@jolelievre jolelievre mentioned this issue May 17, 2024
1 task
@jolelievre jolelievre added develop Branch Theme & logo Label: Which BO under menu is concerned labels May 17, 2024
@Hlavtox
Copy link
Contributor

Hlavtox commented May 20, 2024

A big issue is this that classic is hardcoded in several places in the code, including the translation system - #35299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Theme & logo Label: Which BO under menu is concerned
Projects
None yet
Development

No branches or pull requests

3 participants