Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design issue of module catalog page #27

Closed
marionf opened this issue Aug 20, 2018 · 5 comments
Closed

Design issue of module catalog page #27

marionf opened this issue Aug 20, 2018 · 5 comments

Comments

@marionf
Copy link

marionf commented Aug 20, 2018 •
edited

Following this PR: PrestaShop/PrestaShop#9287
The buttons of the module catalog page with MBO are not very pretty

capture d ecran_177

capture d ecran_178

Also, when I click on Disable/Disable mobile, the button should change for Enable/Enable mobile

mbo-pr9287

And, the number of notifications are not ok

capture d ecran_277
@MrBaiame
Copy link
Contributor

Shouldn't it be something the core team needs to do if they changed it ?

@marionf
Copy link
Author

marionf commented Aug 29, 2018

@eternoendless What do you think ?

@Quetzacoalt91
Copy link
Contributor

The PR has not been merged yet, but you can find the changes to copy on the core here: https://github.com/PrestaShop/PrestaShop/pull/9287/files#diff-8ce12f544e70f168b80a09e88b3391d5R35

MrBaiame added a commit that referenced this issue Sep 14, 2018
@MrBaiame
Merge pull request #33 from PrestaShop/dev
60da37d 
Fix #27 #30 #32 + ajax_loading
@marionf
Copy link
Author

marionf commented Sep 24, 2018 •
edited

I still have this issue

capture d ecran_314

capture d ecran_315

@marionf marionf reopened this Sep 24, 2018
MrBaiame added a commit that referenced this issue Sep 25, 2018
@MrBaiame
Fix #27
17262d9
@marionf
Copy link
Author

marionf commented Sep 25, 2018 •
edited

Fixed by #44

@marionf marionf closed this as completed Sep 25, 2018
MrBaiame added a commit that referenced this issue Sep 26, 2018
@MrBaiame
Merge pull request #44 from PrestaShop/design_issues
ca175c6 
Fix #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Quetzacoalt91 @MrBaiame @marionf @ntiepresta