Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment to constant variable when use none valid void element #6

Closed
StarpTech opened this issue Oct 8, 2018 · 4 comments
Closed

Comments

@StarpTech
Copy link
Member

<form #heroForm (ngSubmit)="onSubmit(heroForm)">
<label foo="bar" />
  <input type="text" class="input too much classes" [(onChange)]="dede" name="test" />
    <button [style.color]="isSpecial ? 'red' : 'green'"></button></form>

will throw in the playground because label is used as void element.

rpc-wrapper.js:13 Uncaught (in promise) Error: Assignment to constant variable.
    at Parser (prettyhtml.browserified.min.js:1)
    at Function.T.parse (prettyhtml.browserified.min.js:1)
    at prettyhtml.browserified.min.js:1
    at prettyhtml.browserified.min.js:1
    at s (prettyhtml.browserified.min.js:1)
    at Object.run (prettyhtml.browserified.min.js:1)
    at n (prettyhtml.browserified.min.js:1)
    at w (prettyhtml.browserified.min.js:1)
    at Function.T.processSync (prettyhtml.browserified.min.js:1)
    at prettyhtml.browserified.min.js:1
@koca
Copy link
Collaborator

koca commented Oct 8, 2018

But is this related to playground?

@koca
Copy link
Collaborator

koca commented Oct 8, 2018

Cause i'm getting this error in terminal:

❯ prettyhtml index.html
TypeError: value.indexOf is not a function
    at realLength (/Users/mesut/.config/yarn/global/node_modules/vfile-reporter/index.js:299:22)
    at parse (/Users/mesut/.config/yarn/global/node_modules/vfile-reporter/index.js:157:29)
    at reporter (/Users/mesut/.config/yarn/global/node_modules/vfile-reporter/index.js:66:18)
    at log (/Users/mesut/.config/yarn/global/node_modules/unified-engine/lib/file-set-pipeline/log.js:25:17)
    at wrapped (/Users/mesut/.config/yarn/global/node_modules/trough/wrap.js:25:19)
    at next (/Users/mesut/.config/yarn/global/node_modules/trough/index.js:58:24)
    at FileSet.done (/Users/mesut/.config/yarn/global/node_modules/trough/wrap.js:56:16)
    at FileSet.emit (events.js:182:13)
    at FileSet.one (/Users/mesut/.config/yarn/global/node_modules/unified-engine/lib/file-set.js:118:10)
    at FileSet.emit (events.js:182:13)

@StarpTech
Copy link
Member Author

@koca I didn't test it yet. I will investigate thanks for validating.

@StarpTech
Copy link
Member Author

Fix in 0.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants