Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra line added under comments containing "if" #60

Closed
bsaf opened this issue Oct 30, 2018 · 3 comments
Closed

Extra line added under comments containing "if" #60

bsaf opened this issue Oct 30, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@bsaf
Copy link

bsaf commented Oct 30, 2018

馃悰 Bug Report

A rogue extra line is being added under comments containing the word "if".

To Reproduce

Steps to reproduce the behaviour:

<!-- Brunch-->
<p>Brunch</p>
<!-- Gifts -->
<p>Gifts</p>

Expected behaviour

Should output the same as the input.

Actual behaviour

<!-- Brunch-->
<p>Brunch</p>
<!-- Gifts -->

<p>Gifts</p>

Context

Just plain HTML5.
@StarpTech
Copy link
Member

StarpTech commented Oct 30, 2018 •
edited

Hi @bsaf thanks for the bug report. Would you like to send a PR?
The issue is here and here. We have to match for starting \s[if not for any if in the comment node.

@StarpTech StarpTech added the bug Something isn't working label Oct 30, 2018
@bsaf
Copy link
Author

bsaf commented Oct 30, 2018

Will do! Will try and do this week. Thanks for the pointer to the code.

@StarpTech StarpTech mentioned this issue Oct 30, 2018
Merged
@StarpTech
Copy link
Member

@bsaf I provide a fix with #61 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsaf @StarpTech